Revert change from % to ^ #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-choi
force-pushed
the
revert-topic-caret
branch
from
eb4ce05 to
cd39dfd
Compare
I think my change of the spec from % to ^ was premature, partially because I now mildly prefer % again, but mostly because it’s what we presented to plenary on August and because it’s what Babel currently supports. This is a tentative change and has no bearing on what the actual final topic token will be. As per #91 (comment). See also #91 (comment), which I think was now premature.
js-choi
force-pushed
the
revert-topic-caret
branch
from
cd39dfd to
665caba
Compare
js-choi
added a commit
to js-choi/babel-website
that referenced
this pull request
Oct 23, 2021
js-choi
added a commit
that referenced
this pull request
Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #91 (comment), I think my change of the spec from
%to^was premature, partially because I now mildly prefer%again, but mostly because it’s what we presented to plenary on August and because it’s what Babel currently supports (see babel/babel#13749).This is a tentative change and has no bearing on what the actual final topic token will be. It’s just a swap to the explainer and spec back to what we presented to the Committee plenary on August.
This will be almost certainly be the last time I switch the topic token until we hold our TC39 incubator sessions for bikeshedding the token in early November.
I plan to merge this in the next few days barring any big objections.