Rest of AggregateError spec #37

chicoxyzzy · 2019-09-25T09:28:41Z

See #27 and #36

Unfinished parts:

~~AggregateError Object Structure description~~
~~I'm not sure how to update prose in 19.5.5 Native Error Types Used in This Standard~~
~~AggregateError.prototype.toString~~

chicoxyzzy · 2019-09-25T09:29:25Z

spec.html

+
+  <emu-clause id="sec-aggregateerror-object-structure">
+    <h1>_AggregateError_ Object Structure</h1>
+    <p>TODO</p>


need help here

NativeError Object Structure description:

When an ECMAScript implementation detects a runtime error, it throws a new instance of one of the _NativeError_ objects defined in <emu-xref href="#sec-native-error-types-used-in-this-standard"></emu-xref>. Each of these objects has the structure described below, differing only in the name used as the constructor name instead of _NativeError_, in the `name` property of the prototype object, and in the implementation-defined `message` property of the prototype object. For each error object, references to _NativeError_ in the definition should be replaced with the appropriate error object name from <emu-xref href="#sec-native-error-types-used-in-this-standard"></emu-xref>.

⚠️ It seems that NativeError Object Structure description should be updated too

How about something like:

When an ECMAScript implementation detects a runtime error, it throws a new instance of one of the _NativeError_ objects defined in <emu-xref href="#sec-native-error-types-used-in-this-standard"></emu-xref> or a new instance of %AggregateError%. Each of these objects has the structure described below, differing only in the name used as the constructor name instead of _NativeError_, in the `name` property of the prototype object, in the implementation-defined `message` property of the prototype object, and in the presence of the %AggregateError%-specific `errors` property.

NativeError Object Structure and AggregateError Object Structure are two separate sections so they need different descriptions

Yeah, I was thinking something like:

For NativeError

When an ECMAScript implementation detects a runtime error, it throws either a new instance of one of the _NativeError_ objects defined in <emu-xref href="#sec-native-error-types-used-in-this-standard"></emu-xref> or a new instance of %AggregateError%. Each of the _NativeError_ objects has the structure described below, differing only in the name used as the constructor name instead of _NativeError_, in the `name` property of the prototype object, in the implementation-defined `message` property of the prototype object, and in the presence of the %AggregateError%-specific `errors` property.

For AggregateError

When an ECMAScript implementation detects a runtime error, it throws either a new instance of one of the _NativeError_ objects defined in <emu-xref href="#sec-native-error-types-used-in-this-standard"></emu-xref> or a new instance of %AggregateError%. Each _AggregateError_ object has the structure described below, differing only in the implementation-defined `message` property of the prototype object.

I've hoisted this to Error Objects decription

spec.html

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

spec.html

mathiasbynens · 2019-09-25T14:00:47Z

spec.html

+
+  <emu-clause id="sec-aggregateerror-object-structure">
+    <h1>_AggregateError_ Object Structure</h1>
+    <p>TODO</p>


How about something like:

When an ECMAScript implementation detects a runtime error, it throws a new instance of one of the _NativeError_ objects defined in <emu-xref href="#sec-native-error-types-used-in-this-standard"></emu-xref> or a new instance of %AggregateError%. Each of these objects has the structure described below, differing only in the name used as the constructor name instead of _NativeError_, in the `name` property of the prototype object, in the implementation-defined `message` property of the prototype object, and in the presence of the %AggregateError%-specific `errors` property.

…section Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

spec.html

ljharb · 2019-09-25T14:40:22Z

spec.html

+<emu-clause id="sec-error-objects">
+  <h1>Error Objects</h1>
+  <p>Instances of Error objects are thrown as exceptions when runtime errors occur. The Error objects may also serve as base objects for user-defined exception classes.</p>
+  <p>When an ECMAScript implementation detects a runtime error, it throws a new instance of one of the _NativeError_ objects defined in <emu-xref href="#sec-native-error-types-used-in-this-standard"></emu-xref> or a new instance of %AggregateError%. Each of these objects has the structure described below, differing only in the name used as the constructor name instead of _NativeError_, in the `name` property of the prototype object, in the implementation-defined `message` property of the prototype object, and in the presence of the %AggregateError%-specific `errors` property.</p>


why is aggregate error not just another one of the native error types?

AggregateError has different constructor behavior than NativeErrors as @bakkot mention in #27

Hmm, I’m not sure that suggestion is in fact the best solution - it ends up duplicating a lot of spec text. Is there a way we could modify the NativeError approach so it could handle AggregateErrors?

I think that it's possible. Will try to figure out

spec.html

Co-Authored-By: Jordan Harband <ljharb@gmail.com>

ljharb

I'm not a super big fan of leaving the NativeError magic in place when it won't work for all native errors - I'd prefer to see it handled in a more explicit way that also encompasses AggregateError.

spec.html

ljharb · 2019-09-25T17:15:59Z

spec.html

+      </emu-clause>
+
+      <emu-clause id="sec-aggregate-error.prototype.errors">
+        <h1>_AggregateError_.prototype.errors</h1>


repeating: there must not be a mutable object data property on the prototype.

AggregateError.prototype.errors must either be absent, a primitive, an accessor that returns a new array every time (either empty, or with the errors if #38 moves forward), or a data property using a frozen array.

Should it be added to Properties of the _AggregateError_ Prototype Object part?

Co-Authored-By: Jordan Harband <ljharb@gmail.com>

…al-promise-any into rest-of-aggregateerror

chicoxyzzy · 2019-09-26T10:28:14Z

Just added "Native Error Types Used in This Standard" prose and AggregateError.prototype.toString implementation. Both need some 👀 on them

Unfortunately, I won't have time for further changes until Monday :(
I would be happy if someone will take care of this PR until then!

spec.html

chicoxyzzy · 2019-09-30T14:09:50Z

@mathiasbynens I've just updated toString method. Not sure if I did it right

mathiasbynens · 2019-09-30T14:17:05Z

spec.html

+          1. Let _errorsNumString_ ! ToString(_errorsNum_).
+          1. If _name_ is the empty String, return _msg_.
+          1. If _msg_ is the empty String, return _name_.
+          1. Return the string-concatenation of _name_, the code unit 0x003A (COLON), the code unit 0x0020 (SPACE), _msg_, "(", _errorsNumString_, " messages)".


This results in "1 messages".

FWIW, I'd be totally okay with leaving this up to implementations, by making it part of the message property. We could have a non-normative note that recommends implementers to include the message count in the error message.

mathiasbynens · 2019-10-01T13:28:14Z

Alright, let's merge this one soon. Any follow-up work can happen in separate PRs. Thanks, @chicoxyzzy!

chicoxyzzy requested review from mathiasbynens and bakkot September 25, 2019 09:28

chicoxyzzy commented Sep 25, 2019

View reviewed changes

mathiasbynens reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

mathiasbynens reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

mathiasbynens reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

mathiasbynens reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

mathiasbynens reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

mathiasbynens reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

mathiasbynens reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

mathiasbynens reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

chicoxyzzy added 3 commits September 25, 2019 16:56

Rest of AggregateError spec

5e0c185

Remove unnecessary list item

df78799

Add The _AggregateError_ Constructors part

79d9bf8

chicoxyzzy force-pushed the rest-of-aggregateerror branch from e6d18a0 to 79d9bf8 Compare September 25, 2019 13:56

chicoxyzzy and others added 7 commits September 25, 2019 16:58

constructor - constructors

6389a45

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

each -> the

165c5a1

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

construtor -> constructors

8811f9e

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

each -> the

e8632b2

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

remove unnecessary text

f42c80e

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

objects -> object

07624af

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

each -> the

51f3dfc

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

mathiasbynens suggested changes Sep 25, 2019

View reviewed changes

chicoxyzzy and others added 3 commits September 25, 2019 17:05

Rephrase AggregateError prototype properties description

b2e5483

add mention of NativeError to Properties of AggregateError Instances …

d66f4d8

…section Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

Update AggragateError and NativeError

235da75

ljharb reviewed Sep 25, 2019

View reviewed changes

spec.html Show resolved Hide resolved

Update link to AggregateError Object Structure section

12f2e1a

ljharb reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

ljharb reviewed Sep 25, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

chicoxyzzy and others added 4 commits September 25, 2019 18:10

Update AggregateError.prototype.errors description

a2eb792

Co-Authored-By: Jordan Harband <ljharb@gmail.com>

Update AggregateError.prototype.name description

1d16f24

Co-Authored-By: Jordan Harband <ljharb@gmail.com>

use %AggregateErrorPrototype% intrinsic

f5431d2

fix AggregateError.prototype description

c3e8e2e

ljharb reviewed Sep 25, 2019

View reviewed changes

chicoxyzzy and others added 5 commits September 26, 2019 11:03

Add AggregateError.prototype.toString method

44b1c52

Update Native Error Types Used in This Standard prose

8b9064c

Update spec.html

d628750

Co-Authored-By: Jordan Harband <ljharb@gmail.com>

Remove unnecessary var tag

43ffa4c

Merge branch 'rest-of-aggregateerror' of github.com:chicoxyzzy/propos…

2fa9b4d

…al-promise-any into rest-of-aggregateerror

chicoxyzzy marked this pull request as ready for review September 26, 2019 10:34

mathiasbynens approved these changes Sep 30, 2019

View reviewed changes

chicoxyzzy mentioned this pull request Sep 30, 2019

AggregateError.prototype.toString #36

Closed

ljharb suggested changes Sep 30, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

chicoxyzzy force-pushed the rest-of-aggregateerror branch from 15b2f1c to 2fa9b4d Compare September 30, 2019 13:43

chicoxyzzy added 2 commits September 30, 2019 15:56

AggregateError.prototype.toString() fixes

a617313

Fix name in AggregateError.prototype.toString()

8ad81ad

mathiasbynens reviewed Sep 30, 2019

View reviewed changes

Remove number of errors from AggregateError.prototype.toString()

2474cfd

mathiasbynens requested a review from ljharb October 1, 2019 13:27

mathiasbynens merged commit 63a6b17 into tc39:master Oct 1, 2019

chicoxyzzy deleted the rest-of-aggregateerror branch October 1, 2019 14:09

chicoxyzzy mentioned this pull request Oct 1, 2019

Should NativeError encompass AggregateError? #39

Closed

bakkot mentioned this pull request Oct 2, 2019

remove AggregateError.prototype.errors #41

Merged

ExE-Boss mentioned this pull request Jun 10, 2020

Normative: Add Promise.any & AggregateError tc39/ecma262#2040

Merged

ExE-Boss mentioned this pull request Aug 6, 2020

Editorial: remove unused %AggregateErrorPrototype% intrinsic tc39/ecma262#2124

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rest of AggregateError spec #37

Rest of AggregateError spec #37

chicoxyzzy commented Sep 25, 2019 •

edited

Loading

chicoxyzzy Sep 25, 2019

chicoxyzzy Sep 25, 2019 •

edited

Loading

chicoxyzzy Sep 25, 2019 •

edited

Loading

mathiasbynens Sep 25, 2019

chicoxyzzy Sep 25, 2019

mathiasbynens Sep 25, 2019 •

edited

Loading

chicoxyzzy Sep 25, 2019

mathiasbynens Sep 25, 2019

ljharb Sep 25, 2019

chicoxyzzy Sep 25, 2019

ljharb Sep 25, 2019

chicoxyzzy Sep 25, 2019

ljharb left a comment

ljharb Sep 25, 2019

chicoxyzzy Sep 30, 2019 •

edited

Loading

chicoxyzzy commented Sep 26, 2019 •

edited

Loading

chicoxyzzy commented Sep 30, 2019

mathiasbynens Sep 30, 2019

mathiasbynens commented Oct 1, 2019

Rest of AggregateError spec #37

Rest of AggregateError spec #37

Conversation

chicoxyzzy commented Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

chicoxyzzy Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

chicoxyzzy Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mathiasbynens Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

For NativeError

For AggregateError

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ljharb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chicoxyzzy Sep 30, 2019 • edited Loading

Choose a reason for hiding this comment

chicoxyzzy commented Sep 26, 2019 • edited Loading

chicoxyzzy commented Sep 30, 2019

Choose a reason for hiding this comment

mathiasbynens commented Oct 1, 2019

chicoxyzzy commented Sep 25, 2019 •

edited

Loading

chicoxyzzy Sep 25, 2019 •

edited

Loading

chicoxyzzy Sep 25, 2019 •

edited

Loading

mathiasbynens Sep 25, 2019 •

edited

Loading

For `NativeError`

For `AggregateError`

chicoxyzzy Sep 30, 2019 •

edited

Loading

chicoxyzzy commented Sep 26, 2019 •

edited

Loading