This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
[spec] change errors from a prototype accessor to an own data property
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicoxyzzy
approved these changes
May 24, 2020
mathiasbynens
approved these changes
May 24, 2020
bakkot
reviewed
May 26, 2020
jorendorff
reviewed
May 27, 2020
|
Was this intentionally changed to be an enumerable property? Before #43, |
|
Yeah, it should be non-enumerable: see #31 / #14 (comment). |
|
Whoops, thanks. Will fix. |
bakkot
reviewed
May 28, 2020
mathiasbynens
approved these changes
May 29, 2020
|
This PR now includes 2 unrelated commits. Could you rebase? |
|
whoops, not sure how i did that. fixed! |
mathiasbynens
approved these changes
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38.