Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align proposal spec to latest ecma262 spec text #14

Closed
wants to merge 2 commits into from

Conversation

rbuckton
Copy link
Collaborator

This updates the proposal specification text to match the latest text from http://github.com/tc39/ecma262. No normative changes are implied by this update.

The resulting proposal specification text is now much smaller as we can leverage the new RegExp Record in lieu of our own "Modifiers Record", since RegExp Records now thread throughout the pattern semantics in the same way, carrying the same information, so fewer changes are necessary.

Fixes #12
Fixes #13

Copy link

A preview of this PR can be found at https://tc39.es/proposal-regexp-modifiers/pr/14.

@rbuckton
Copy link
Collaborator Author

@syg, @michaelficarra, @bakkot: editor review would be appreciated.
@waldemarhorwat: this should also address your outstanding feedback in #4 as well.

Copy link

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so straightforward now! LGTM.

You may wish to bump the ecma262-biblio dependency to pull in the dfn for RegExp Record.

@rbuckton
Copy link
Collaborator Author

rbuckton commented Oct 8, 2024

Closing as the official specification text can be found at https://arai-a.github.io/ecma262-compare/?pr=3221 and soon on https://tc39.es/ecma262 as the proposal has reached Stage 4.

@rbuckton rbuckton closed this Oct 8, 2024
@ljharb ljharb deleted the update-ecma262 branch October 8, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants