This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Normative: Don't consider 0-length TypedArrays out of bounds #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The NOTE says "0-length TypedArrays", but this only applies to 0-length TAs which start at precisely the end of the underlying buffer, right? |
|
Correct. |
jugglinmike
added a commit
to tc39/test262
that referenced
this pull request
Aug 25, 2021
A recent normative change to the Resizable ArrayBuffer modified the criteria for a TypedArray becoming "out of bounds." Following the change, TypedArrays which track the length of their underlying ArrayBuffer instance are no longer considered "out of bounds" when the ArrayBuffer is resized such that its size matches the TypedArray's offset exactly. tc39/proposal-resizablearraybuffer#70 The majority of this patch's changes extend coverage to include cases for both "on boundary" and "out of bounds" without reflecting any new semantics. Two changes describe observable differences in the new version of the algorithm: - out-of-bounds-when-species-retrieved-different-type.js - out-of-bounds-when-species-retrieved-same-type.js
|
Corresponding Test262 changes: tc39/test262#3163 |
rwaldron
pushed a commit
to tc39/test262
that referenced
this pull request
Aug 25, 2021
A recent normative change to the Resizable ArrayBuffer modified the criteria for a TypedArray becoming "out of bounds." Following the change, TypedArrays which track the length of their underlying ArrayBuffer instance are no longer considered "out of bounds" when the ArrayBuffer is resized such that its size matches the TypedArray's offset exactly. tc39/proposal-resizablearraybuffer#70 The majority of this patch's changes extend coverage to include cases for both "on boundary" and "out of bounds" without reflecting any new semantics. Two changes describe observable differences in the new version of the algorithm: - out-of-bounds-when-species-retrieved-different-type.js - out-of-bounds-when-species-retrieved-same-type.js
jugglinmike
added a commit
to tc39/test262
that referenced
this pull request
Sep 23, 2021
Following a recent normative change to the Resizable ArrayBuffer proposal [1], the term "out of bounds" no longer applies to "length-tracking" TypedArrays whose underlying ArrayBuffer has been resized to match their byte offset. Reflect this in the tests by renaming the condition from "out of bounds" to "on boundary" and by adding new assertions for true "out of bounds" conditions. [1] tc39/proposal-resizablearraybuffer#70
rwaldron
pushed a commit
to tc39/test262
that referenced
this pull request
Sep 23, 2021
Following a recent normative change to the Resizable ArrayBuffer proposal [1], the term "out of bounds" no longer applies to "length-tracking" TypedArrays whose underlying ArrayBuffer has been resized to match their byte offset. Reflect this in the tests by renaming the condition from "out of bounds" to "on boundary" and by adding new assertions for true "out of bounds" conditions. [1] tc39/proposal-resizablearraybuffer#70
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68