Spec fixes, applies review feedback #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codehag
approved these changes
May 20, 2021
syg
approved these changes
May 20, 2021
spec.html
Outdated
| 1. If _inFunction_ is *false*, and _body_ Contains |NewTarget|, throw a *SyntaxError* exception. | ||
| 1. If _inMethod_ is *false*, and _body_ Contains |SuperProperty|, throw a *SyntaxError* exception. | ||
| 1. If _inDerivedConstructor_ is *false*, and _body_ Contains |SuperCall|, throw a *SyntaxError* exception. | ||
| 1. If _body_ Contains |NewTarget|, throw a *SyntaxError* exception. |
There was a problem hiding this comment.
Nit: Here and below, it should _body_ Contains |Foo| is *true*
caridy
reviewed
May 20, 2021
| @@ -136,17 +137,14 @@ <h1>PerformRealmEval ( _sourceText_, _callerRealm_, _evalRealm_ )</h1> | |||
| 1. Assert: _callerRealm_ is a Realm Record. | |||
| 1. Assert: _evalRealm_ is a Realm Record. | |||
| 1. Perform ? HostEnsureCanCompileStrings(_callerRealm_, _evalRealm_). | |||
| 1. Let _inFunction_ be *false*. | |||
There was a problem hiding this comment.
this form was copied from https://tc39.es/ecma262/#sec-performeval. My bad, because the flag for direct eval is not longer needed, therefore these lets declarations are not needed anymore. Good catch!
caridy
reviewed
May 20, 2021
| 1. For each element _key_ of _argumentsList_, do | ||
| 1. Let _o_ be _argumentsList_[_key_]. | ||
| 1. Set _argumentsList_[_key_] to ? GetWrappedValue(_targetRealm_, _o_). | ||
| 1. Let _wrappedArgs_ be a new empty List. |
There was a problem hiding this comment.
this was me being lazy! jajaja... good catch!
caridy
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #304 (comment)