Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really bad unwatch performance (3000%) #215

Open
lifeart opened this issue Apr 30, 2024 · 2 comments
Open

Really bad unwatch performance (3000%) #215

lifeart opened this issue Apr 30, 2024 · 2 comments

Comments

@lifeart
Copy link

lifeart commented Apr 30, 2024

Hello! Thank you for great work and all movements here!

I'm maintainer of https://github.com/lifeart/glimmer-next (glimmer-vm runtime alternative for Ember)
Repo using reactive approach very close to signals, based on this reactivity concept: lifeart/glimmer-next#41

I'm trying to be more native and experimenting with drop-in replacement with signals polyfill.
During testing I observe 10x performance degradation, especially on cleanup cases:

image

clearManyItems1End phase estimated regression +3750ms [3727ms to 3783ms] OR +3214.31% [3194.71% to 3242.69%]

artifact-1.pdf

here is PR i'm testing on: lifeart/glimmer-next#114

@littledan
Copy link
Member

Thanks for reporting this! PRs welcome to improve performance.

@lifeart
Copy link
Author

lifeart commented May 1, 2024

Linking one more issue: proposal-signals/signal-polyfill#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants