Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: clarify "integral part" #1890

Closed
Ms2ger opened this issue Oct 26, 2021 · 4 comments · Fixed by #2157
Closed

Editorial: clarify "integral part" #1890

Ms2ger opened this issue Oct 26, 2021 · 4 comments · Fixed by #2157
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@Ms2ger
Copy link
Collaborator

Ms2ger commented Oct 26, 2021

We don't explicitly define "integral part" anywhere, and neither does 262, afaict. We should fix that.
@Ms2ger Ms2ger added spec-text Specification text involved editorial labels Oct 26, 2021
@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Oct 26, 2021

Oh, this is RoundTowardsZero(), isn't it?

@ptomato
Copy link
Collaborator

ptomato commented Oct 26, 2021

Does that mean we should replace all uses of "the integral part of x" with "! RoundTowardsZero(x)"?

@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Oct 28, 2021

That seems like a reasonable solution, yeah.

@ptomato ptomato self-assigned this Apr 26, 2022
@ptomato
Copy link
Collaborator

ptomato commented Apr 26, 2022

Taking this, I'll need to use RoundTowardsZero in #519, and I almost added more "integral part" language because it was already present.

ptomato added a commit that referenced this issue Apr 26, 2022
@ptomato
Editorial: Drop "integral part of" language
6a4586a 
The term "integral part of" isn't defined anywhere. Instead, we have an
abstract operation for this already.

Closes: #1890
@ptomato ptomato mentioned this issue Apr 26, 2022
Merged
Ms2ger pushed a commit that referenced this issue Apr 27, 2022
@ptomato @Ms2ger
Editorial: Drop "integral part of" language
6ec1608 
The term "integral part of" isn't defined anywhere. Instead, we have an
abstract operation for this already.

Closes: #1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Drop "integral part of" language tc39/proposal-temporal
2 participants
@Ms2ger @ptomato