New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoundDuration: Consider calling ToTemporalDate(relativeTo) only when needed #2247

Closed

anba opened this issue May 31, 2022 · 1 comment · Fixed by #2657

Labels

non-prod-polyfill normative spec-text

Milestone

Contributor

anba commented May 31, 2022

RoundDuration, step 6 is only executed when needed:

If unit is one of "year", "month", "week", or "day", then
...

But step 4 is unconditionally executed, even though relativeTo is only needed for "year", "month", and "week":

If relativeTo is not undefined, then
...

This would be an observable change, because ToTemporalDate(relativeTo) can call user code.

The text was updated successfully, but these errors were encountered:

ptomato added spec-text non-prod-polyfill normative labels

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

34e700b

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

Closes: #2247

ptomato mentioned this issue

Normative: Call user code on relativeTo only when necessary in RoundDuration #2346

Closed

Collaborator

ptomato commented Jul 6, 2022

There are several other places where a ZonedDateTime relativeTo is converted with ToTemporalDate during a duration.round() operation, including in UnbalanceDurationRelative. We should make sure it is converted only once.

ptomato added this to the Stage "3.5" milestone

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

f6f0ee8

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

e5ab49f

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

1da204b

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, and only once. Previously, it could be converted up
to a few separate times in each operation, such as
UnbalanceDurationRelative, RoundDuration, and BalanceDurationRelative.
Since the conversion is user-visible, we don't want to perform it when not
necessary or perform it more times than necessary.

Closes: #2247

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

f7796f5

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

08753f0

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

db4cfee

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, and only once. Previously, it could be converted up
to a few separate times in each operation, such as
UnbalanceDurationRelative, RoundDuration, and BalanceDurationRelative.
Since the conversion is user-visible, we don't want to perform it when not
necessary or perform it more times than necessary.

Closes: #2247

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

b709d4c

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

8c8b6c7

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

ba5a3d2

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

ceb60b3

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

c8cb2fe

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

b4ffe4c

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

c0f7343

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

4dd99ca

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

41cc54c

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

3183cc4

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

4f30cb5

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

c5ac8ec

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

df3e607

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

b088fb2

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

b458389

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

c4256df

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

c416391

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

b8dd74a

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

47c12f6

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

bd1ae6b

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

6f07bda

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

db6bbf7

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

aa5747f

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

abb5207

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

a6c68d0

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

9e0be84

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

7da660f

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

1e1e313

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato mentioned this issue

Audit of user code calls, part 2 #2657

Merged

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

aaba929

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

4b7e274

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

90f549d

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

5a40db5

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

8aebe23

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

65954ad

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

046482e

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

7d06b60

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

ded5a87

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

c60c39d

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

bc1307a

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

a203d8a

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

d9f043a

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

ptomato closed this as completed in #2657

ptomato added a commit that referenced this issue


          Normative: Call user code on relativeTo only when necessary in RoundD…

540dc4d

…uration

relativeTo as a PlainDate is only needed when smallestUnit is year, month,
or week. relativeTo as a ZonedDateTime is used additionally when
smallestUnit is day. However, ToTemporalDate only needs to be called in
the former case. Since ToTemporalDate potentially calls user code,
rearrange some steps to make sure to call it only when necessary.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Don't convert relativeTo to PlainDate twice in Duration.co…

e9b9a6f

…mpare

We call UnbalanceDurationRelative twice with the same relativeTo object.
UnbalanceDurationRelative only uses plain or undefined relativeTo, not
zoned, so it will convert it with ToTemporalDate. No need to do this
twice; pre-convert it before the first call.

See: #2247

ptomato added a commit that referenced this issue


          Normative: Separate zoned and plain operations in RoundDuration

742248e

This converts a ZonedDateTime relativeTo into a PlainDateTime relativeTo
only when necessary, only after potentially throwing other errors, and
only once. Previously, it could be converted up to a few separate times in
each operation, such as UnbalanceDurationRelative, RoundDuration, and
BalanceDurationRelative. Since the conversion is user-visible, we don't
want to perform it when not necessary or perform it more times than
necessary.

Closes: #2247
Closes: #2529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment