New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields operation on calendar #666

Closed

ptomato opened this issue Jun 11, 2020 · 0 comments · Fixed by #1014

Assignees

Labels

documentation non-prod-polyfill spec-text

Milestone

Stable proposal

Collaborator

ptomato commented Jun 11, 2020

Follow up from #638. The calendar needs a way to say which fields are relevant for a particular operation. A getFields() method was previously suggested in #520 (comment).

I wonder if this should be a method on the calendar, or maybe we should get the list of fields from the calendar and then remove 'day'.

Originally posted by @sffc in #638

One way to do it would be to pass a list of fields into the method and the calendar would return a modified list of fields. E.g.

JapaneseCalendar.prototype.getFields = function(fields) {
  if ('year' in fields)
    fields.push('era')
  return fields;
}

(only without modifying the original array)

The text was updated successfully, but these errors were encountered:

ptomato mentioned this issue

ISO 8601 calendar #638

Merged

4 tasks

ptomato added this to the Stable proposal milestone

ptomato added documentation spec-text non-prod-polyfill labels

ptomato self-assigned this

ptomato mentioned this issue

Various spec improvements #1011

Merged

ptomato added a commit that referenced this issue


          Add various calendar TODOs to spec

c3feaa4

These are not done yet, but in order for the spec changes for the fields()
method to make sense, they at least need to be marked as such.

See: #666

ptomato added a commit that referenced this issue


          Split date and time operations in DateTime.with()

172df07

This is reflected in the polyfill but not yet in the spec. It's also not
complete, since it will change anyway due to #522, but it's enough to make
the spec changes for calendar.fields make sense.

See: #666

ptomato added a commit that referenced this issue


          Add Calendar.fields method

acb96bf

The Calendar.fields method is called whenever Temporal needs to determine
if a calendar object requires extra fields to uniquely identify its date.

Closes: #666

ptomato mentioned this issue

Calendar.fields method #1014

Merged

ptomato added a commit that referenced this issue


          Add various calendar TODOs to spec

0f383b4

These are not done yet, but in order for the spec changes for the fields()
method to make sense, they at least need to be marked as such.

See: #666

ptomato added a commit that referenced this issue


          Split date and time operations in DateTime.with()

cb7d1e6

This is reflected in the polyfill but not yet in the spec. It's also not
complete, since it will change anyway due to #522, but it's enough to make
the spec changes for calendar.fields make sense.

See: #666

ptomato added a commit that referenced this issue


          Add Calendar.fields method

744711a

The Calendar.fields method is called whenever Temporal needs to determine
if a calendar object requires extra fields to uniquely identify its date.

Closes: #666

ptomato added a commit that referenced this issue


          Add Calendar.fields method

113fa29

The Calendar.fields method is called whenever Temporal needs to determine
if a calendar object requires extra fields to uniquely identify its date.

Closes: #666

ptomato added a commit that referenced this issue


          Add various calendar TODOs to spec

6c28050

These are not done yet, but in order for the spec changes for the fields()
method to make sense, they at least need to be marked as such.

See: #666

ptomato added a commit that referenced this issue


          Split date and time operations in DateTime.with()

b3bd658

This is reflected in the polyfill but not yet in the spec. It's also not
complete, since it will change anyway due to #522, but it's enough to make
the spec changes for calendar.fields make sense.

See: #666

ptomato added a commit that referenced this issue


          Add Calendar.fields method

9dcf449

The Calendar.fields method is called whenever Temporal needs to determine
if a calendar object requires extra fields to uniquely identify its date.

Closes: #666

ptomato added a commit that referenced this issue


          Add Calendar.fields method

292b17f

The Calendar.fields method is called whenever Temporal needs to determine
if a calendar object requires extra fields to uniquely identify its date.

Closes: #666

Ms2ger closed this as completed in #1014

Ms2ger pushed a commit that referenced this issue


          Add various calendar TODOs to spec

7fa6e57

These are not done yet, but in order for the spec changes for the fields()
method to make sense, they at least need to be marked as such.

See: #666

Ms2ger pushed a commit that referenced this issue


          Split date and time operations in DateTime.with()

e66eb4d

This is reflected in the polyfill but not yet in the spec. It's also not
complete, since it will change anyway due to #522, but it's enough to make
the spec changes for calendar.fields make sense.

See: #666

Ms2ger pushed a commit that referenced this issue


          Add Calendar.fields method

efdb545

The Calendar.fields method is called whenever Temporal needs to determine
if a calendar object requires extra fields to uniquely identify its date.

Closes: #666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment