-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the default, optional-ness, etc. for era
and non-ISO calendar fields
#902
Comments
Hmm, maybe this?
I don't know if we want the default values for the other properties to be determined by the calendar. Although, I guess we have no choice, since 0 is an invalid value for |
Yep. Would this imply a change to CalendarProtocol? Or just a change in how the polyfill is implemented?
I would probably split into two paragraphs for clarity: one focused on the calendar, and a follow-up paragraph focused on other fields including defaults. Then you'll have prepared the user (who may not even know what a calendar is) before talking about calendar-dependent info.
|
The docs for DateTime.from say:
What about
era
? What about additional non-ISO calendar fields?Seems like we should have some more generalized text here, e.g.
BTW, I have no idea what the default
era
value should be. See #901.The text was updated successfully, but these errors were encountered: