Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Remove "designed to be subclassable" #1677

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Jul 23, 2021

See tc39/ecma262#2360

Bring the language around this in line with the main ECMA-262 text, using
the same unordered list form and the same bullet points everywhere.

See tc39/ecma262#2360

Bring the language around this in line with the main ECMA-262 text, using
the same unordered list form and the same bullet points everywhere.
@ptomato ptomato requested a review from Ms2ger July 23, 2021 22:54
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #1677 (dba4162) into main (3337074) will decrease coverage by 22.22%.
The diff coverage is n/a.

❗ Current head dba4162 differs from pull request most recent head 5a7f958. Consider uploading reports for the commit 5a7f958 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1677       +/-   ##
===========================================
- Coverage   95.02%   72.79%   -22.23%     
===========================================
  Files          19       18        -1     
  Lines       10778     4838     -5940     
  Branches     1725     1058      -667     
===========================================
- Hits        10242     3522     -6720     
- Misses        523     1030      +507     
- Partials       13      286      +273     
Flag Coverage Δ
test262 72.79% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/calendar.mjs 23.22% <0.00%> (-71.15%) ⬇️
polyfill/lib/intl.mjs 65.55% <0.00%> (-34.45%) ⬇️
polyfill/lib/instant.mjs 79.13% <0.00%> (-15.31%) ⬇️
polyfill/lib/plainmonthday.mjs 79.01% <0.00%> (-14.14%) ⬇️
polyfill/lib/plainyearmonth.mjs 83.42% <0.00%> (-12.99%) ⬇️
polyfill/lib/ecmascript.mjs 82.79% <0.00%> (-12.28%) ⬇️
polyfill/lib/plaindatetime.mjs 85.14% <0.00%> (-12.17%) ⬇️
polyfill/lib/timezone.mjs 81.66% <0.00%> (-11.80%) ⬇️
polyfill/lib/zoneddatetime.mjs 89.41% <0.00%> (-8.99%) ⬇️
polyfill/lib/duration.mjs 90.38% <0.00%> (-7.70%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3337074...5a7f958. Read the comment docs.

@ptomato ptomato changed the title Remove "designed to be subclassable" Editorial: Remove "designed to be subclassable" Jul 27, 2021
@Ms2ger Ms2ger merged commit 8bc9cd7 into main Jul 27, 2021
@Ms2ger Ms2ger deleted the not-designed-to-be-subclassable branch July 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants