Editorial: Add missing check in ParseTemporalInstant. #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this check, we hit an assertion failure in CreateTemporalInstant, so I'm considering the change to be editorial.
Codecov Report
@@ Coverage Diff @@
## main #2084 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 19 19
Lines 10986 10986
Branches 1580 1580
=======================================
Hits 10145 10145
Misses 821 821
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check, we hit an assertion failure in CreateTemporalInstant, so I'm considering the change to be editorial.