Normative: Avoid ToString(calendar) when the calendar-id is unused
#2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2269 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 19 19
Lines 10465 10466 +1
Branches 1678 1680 +2
=======================================
+ Hits 9518 9519 +1
Misses 939 939
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ptomato
approved these changes
Jun 30, 2022
ptomato
added
spec-text
gibson042
approved these changes
Jul 6, 2022
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Jul 29, 2022
…lendar) This implements the normative change in tc39/proposal-temporal#2269 which reached consensus at the July 2022 TC39 meeting. There was already a test for PlainDate for this topic, which needs to be adjusted to accommodate the normative change. Tests for PlainDateTime and ZonedDateTime did not yet exist, so add new ones based on the PlainDate test.
ptomato
force-pushed
the
calendar-to-string
branch
from
70088a4
to
1a0e382
Compare
|
This change achieved consensus in the July 2022 TC39 meeting. I've added another commit to bring the reference code in sync with the spec change. Since that will break tests, we should wait until tc39/test262#3623 is merged and update the test262 submodule commit as part of merging this. |
ljharb
reviewed
Jul 30, 2022
ptomato
force-pushed
the
calendar-to-string
branch
from
1a0e382
to
a5a8186
Compare
Ms2ger
pushed a commit
to tc39/test262
that referenced
this pull request
Aug 3, 2022
…lendar) This implements the normative change in tc39/proposal-temporal#2269 which reached consensus at the July 2022 TC39 meeting. There was already a test for PlainDate for this topic, which needs to be adjusted to accommodate the normative change. Tests for PlainDateTime and ZonedDateTime did not yet exist, so add new ones based on the PlainDate test.
|
tc39/test262#3623 is merged |
`TemporalZonedDateTimeToString` doesn't call `ToString(timeZone)` when `showTimeZone == "never"`. Do the same for `ToString(calendar)`. `TemporalYearMonthToString` and `TemporalMonthDayToString` weren't changed because both have to special-case non-ISO-8601 calendars.
The repeated normative change in the previous commit goes into its own abstract operation, MaybeFormatCalendarAnnotation. While we are at it, updates FormatCalendarAnnotation to use a structured header, and updates the link in the editor's note.
Implements the normative change in the previous commit in the polyfill, for the purpose of verifying test262 tests.
ptomato
force-pushed
the
calendar-to-string
branch
from
a5a8186
to
2ae54ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemporalZonedDateTimeToStringdoesn't callToString(timeZone)whenshowTimeZone == "never". Do the same forToString(calendar).TemporalYearMonthToStringandTemporalMonthDayToStringweren'tchanged because both have to special-case non-ISO-8601 calendars.