Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Add "22" to TimeHourNotValidMonth #2280

Closed
wants to merge 1 commit into from

Conversation

anba
Copy link
Contributor

@anba anba commented Jun 9, 2022

Likely an unintentional omission, but still a normative change.

Fixes #2239

Likely an unintentional omission, but still a normative change.

Fixes tc39#2239
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2280 (dc8b4ee) into main (1b3d018) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2280   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          19       19           
  Lines       10528    10528           
  Branches     1699     1699           
=======================================
  Hits         9587     9587           
  Misses        929      929           
  Partials       12       12           
Flag Coverage Δ
test262 83.30% <ø> (ø)
tests 81.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3d018...dc8b4ee. Read the comment docs.

Copy link
Collaborator

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, dang.

@ptomato ptomato added the normative Would be a normative change to the proposal label Jun 14, 2022
@ptomato ptomato marked this pull request as draft June 14, 2022 14:40
@ptomato
Copy link
Collaborator

ptomato commented Jun 30, 2022

Subsumed by #2284.

@ptomato ptomato closed this Jun 30, 2022
@anba anba deleted the TimeHourNotValidMonth-2239 branch August 4, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
normative Would be a normative change to the proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeHourNotValidMonth should include "22"
4 participants