Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Add an explicit operation for merging calendar field names #2294

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

anba
Copy link
Contributor

@anba anba commented Jun 13, 2022

"with duplicate elements removed" can be ambiguous, for example the result of «"a", "b", "a"» could either be «"a", "b"» or «"b", "a"».

"with duplicate elements removed" can be ambiguous, for example the result of
«"a", "b", "a"» could either be «"a", "b"» or «"b", "a"».
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #2294 (ca8677b) into main (0409774) will decrease coverage by 9.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   91.03%   81.84%   -9.19%     
==========================================
  Files          19       17       -2     
  Lines       10558    10539      -19     
  Branches     1695     1478     -217     
==========================================
- Hits         9611     8626     -985     
- Misses        934     1869     +935     
- Partials       13       44      +31     
Flag Coverage Δ
test262 ?
tests 81.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/plainyearmonth.mjs 43.36% <0.00%> (-32.66%) ⬇️
polyfill/lib/plaintime.mjs 37.82% <0.00%> (-31.38%) ⬇️
polyfill/lib/plainmonthday.mjs 51.06% <0.00%> (-31.21%) ⬇️
polyfill/lib/plaindate.mjs 56.06% <0.00%> (-26.23%) ⬇️
polyfill/lib/plaindatetime.mjs 53.26% <0.00%> (-25.06%) ⬇️
polyfill/lib/instant.mjs 76.11% <0.00%> (-14.93%) ⬇️
polyfill/lib/zoneddatetime.mjs 87.14% <0.00%> (-11.10%) ⬇️
polyfill/lib/duration.mjs 69.93% <0.00%> (-10.68%) ⬇️
polyfill/lib/now.mjs 91.22% <0.00%> (-8.78%) ⬇️
polyfill/lib/timezone.mjs 85.35% <0.00%> (-8.29%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0409774...ca8677b. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@ptomato ptomato enabled auto-merge (rebase) June 13, 2022 16:02
@ptomato ptomato merged commit 2bd7977 into tc39:main Jun 13, 2022
@anba anba deleted the CalendarMergeFieldNames branch June 14, 2022 07:34
@anba anba mentioned this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants