Various editorial issues from Anba's feedback #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feedback from an implementation asked for clarification on this.
It's not possible to directly create a PlainYearMonth or PlainMonthDay
given a full date in a non-ISO calendar. To create it directly, you need
the ISO date of the first day of the PlainYearMonth, or the ISO date of
the PlainMonthDay in the reference year, respectively. Only the calendar
has this knowledge.
(For example, today's date 2023-01-05 in the Hebrew calendar is 12 Tevet
5783. If you want the PlainYearMonth of Tevet 5783, you need to create it
with a reference ISO date of 2022-12-25. This is accomplished by the
CalendarYearMonthFromFields call, where _fields_ is something like
`{ year: 5783, monthCode: 'M04' }`.)
See: #1502
For consistency with GetOffsetNanosecondsFor, and because it does not require a builtin time zone.
…meFor For consistency with GetOffsetNanosecondsFor, and because it does not require a builtin time zone.
For consistency with GetOffsetNanosecondsFor, and because it does not require a builtin time zone.
Codecov Report
@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
- Coverage 94.94% 94.93% -0.01%
==========================================
Files 20 20
Lines 10891 10879 -12
Branches 1954 1954
==========================================
- Hits 10340 10328 -12
Misses 504 504
Partials 47 47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ms2ger
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames and clarifications to address a few of the remaining checklist items in #1502. While we're here, convert the renamed AOs to have structured headers.