Editorial: update deps and fix issues #2746
Conversation
VoltrexKeyva
commented
Dec 31, 2023
VoltrexKeyva
commented
- Update all developer dependencies to their latest versions (including major updates).
- Update files to conform to the new versions and fix some issues:
- Enum values should be lowercase and kebab-case.
- Avoid declaring variables that are already declared, either set their value or rename them accordingly.
- Avoid using abrupt shorthands on abstract or syntax-directed operations that do not return a Completion Record.
- Avoid calling abstract functions in algorithms that don't have a definition.
- Update section names to their new ones.
- Fix a small formatting issue.
VoltrexKeyva
force-pushed
the
update-all
branch
2 times, most recently
from
6377cf0 to
dac670c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2746 +/- ##
==========================================
- Coverage 96.73% 96.38% -0.36%
==========================================
Files 21 21
Lines 12444 12444
Branches 2255 2250 -5
==========================================
- Hits 12038 11994 -44
- Misses 349 395 +46
+ Partials 57 55 -2 ☔ View full report in Codecov by Sentry. |
VoltrexKeyva
force-pushed
the
update-all
branch
from
dac670c to
9725fd2
Compare
|
Fixed merge conflicts. |
There was a problem hiding this comment.
Thanks for doing this! It's a chore which I haven't had time for recently, so I'm glad you stepped up.
All looks fine, but the parts which are copied from ECMA-262 (spec/mainadditions.html) and ECMA-402 (spec/intl.html) need a bit of extra attention — since these are sections that modify existing specs, the original text should be kept in sync with those specs as much as possible. (However, if the section has been totally rewritten as some of the ECMA-402 sections have, it's OK with me to leave it as is for now and just fix the linter issues; we can do that update at a later time.)
|
I've done that update now, in #2749. Rebasing on that PR should make most of my review comments obsolete. |
- Update all developer dependencies to their latest versions (including
major updates).
- Update files to conform to the new versions and fix some issues:
- Enum values should be lowercase and kebab-case.
- Avoid declaring variables that are already declared, either set
their value or rename them accordingly.
- Avoid using abrupt shorthands on abstract or syntax-directed
operations that do not return a Completion Record.
- Avoid calling abstract functions in algorithms that don't have a
definition.
- Update section names to their new ones.
- Fix a small formatting issue.
