Fewer CalendarDay/CalendarDateFromFields calls during PlainYearMonth add/subtract #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2798 +/- ##
==========================================
- Coverage 96.60% 96.60% -0.01%
==========================================
Files 23 23
Lines 12312 12304 -8
Branches 2272 2272
==========================================
- Hits 11894 11886 -8
Misses 356 356
Partials 62 62 ☔ View full report in Codecov by Sentry. |
9 tasks
|
After #2826 we should rewrite this to be an editorial PR. Marking as draft for now. |
… doing PlainYearMonth math
…addition Spec text algorithm corresponding to the previous commit. There is no need to convert the end-of-month ISO date to a calendar date and then back to an ISO date. This looks like it might have removed an observable step, but I think CalendarDateFromFields could already not throw here, because of the assertion that _endOfMonth_ was a valid ISO date within range.
ptomato
force-pushed
the
fewer-calls-pym-math
branch
from
fe4ad56 to
4150c9e
Compare
ptomato
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating for #2794 (ultimately unsuccessful), I uncovered a way to have less user-code calls from PlainYearMonth add/subtract.
I don't see it in the calendar invariants list, but this axiom probably goes without saying: the day before the first day of one month is the last day of the previous month.
If add/subtract moves backward in time, the algorithm requires us to determine the last day of the current month before proceeding with PlainDate-style add/subtract.
Right now, the last day is being determined, but seems unnecessary to thread it back through
CalendarDateFromFields, no?Adjusted tests:
tc39/test262@main...fullcalendar:test262:temporal-fewer-calls-pym-math