-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explainer for API changes for calendar support #287
Conversation
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
==========================================
- Coverage 78.06% 78.03% -0.03%
==========================================
Files 17 17
Lines 3410 3410
Branches 338 338
==========================================
- Hits 2662 2661 -1
Misses 733 733
- Partials 15 16 +1
Continue to review full report at Codecov.
|
Thanks for all the comments! I created issues for all of the open questions. Let me know if I missed any. I plan to merge this PR soon. |
I have opened issues for outstanding issues. I'd like to keep remaining comments on this PR limited in scope to editorial issues. As soon as I have an LGTM I will merge the explainer into the repo, which should have all open questions labeled as such. Once the explainer is merged, we can contribute follow-on PRs as the open questions are addressed. |
Sorry for missing the Temporal meeting and this thread, but I'm missing something here: What's the motivation for a programmable calendar API, as opposed to just using an implementation-defined set of strings for calendars, like Intl does? I'm curious, is it possible to get at the PartialIsoCalendar and mess with it? |
Follow-up: #298
@pipobscure has an AI to make a polyfill for this from the Temporal monthly sync meeting this morning. |
Sorry, by "mess with it" I didn't mean try it out in a polyfill, but rather monkey-patch it and change the behavior of other Temporal.DateTime instances. |
I made a doc detailing my understanding of the state of the Temporal calendar design, following the 10+ hours of discussions this week at TC39.
@pipobscure @robpalme @apaprocki @spectranaut @caiolima