Skip to content
This repository has been archived by the owner on Aug 29, 2021. It is now read-only.

Normative: Fix state checking in async cycle case #96

Merged
merged 1 commit into from
May 31, 2019

Conversation

littledan
Copy link
Member

If a cycle contains async modules, then its statuses will not be set
to "evaluating-async" until after the cycle is traversed. This could
cause errors in setting up the async dependency graph edges. This PR
uses different checks to avoid the issue.

Fixes #89

If a cycle contains async modules, then its statuses will not be set
to "evaluating-async" until after the cycle is traversed. This could
cause errors in setting up the async dependency graph edges. This PR
uses different checks to avoid the issue.

Fixes tc39#89
Copy link
Collaborator

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nicer than using "evaluating-async" for this check. The only thing I would add is that we have three "evaluating" checks through the steps here, which might be able to be combined in some way, but that's entirely editorial.

@littledan littledan merged commit c4a8b46 into tc39:master May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module can be executed before dependencies
2 participants