Remove rocket column #174
Merged
Remove rocket column #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think either we keep the columns everywhere, or remove them everywhere. The columns being temporarily unused doesn’t mean they won’t be used the next time something is ready for advancement. |
|
I'll keep this PR open and update it as soon as we'll have a decision on #173 |
chicoxyzzy
force-pushed
the
remove_unused_rockets
branch
from
d6ac956 to
9a027a2
Compare
michaelficarra
approved these changes
Dec 19, 2018
ljharb
requested changes
Dec 19, 2018
ljharb
changed the title
ljharb
force-pushed
the
remove_unused_rockets
branch
from
9a027a2 to
58fe3d1
Compare
ljharb
force-pushed
the
remove_unused_rockets
branch
from
58fe3d1 to
16d8a0d
Compare
ljharb
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes columns with rocket only from those pages where they aren't used (see #161) and keeps that column for active stage 1+ proposals page till rockets there will be replaced by #173 (WIP)
stage-0-proposals.md rendered version
ecma402/README.md rendered version
ecma402/stage-0-proposals.md rendered version
closes #161