✨ add notes history for Promise.withResolvers() #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 14, 2024
ctcpip
force-pushed
the
history-example
branch
from
5406573 to
c524a79
Compare
|
Looks pretty good! altho at this point it seems better to use the |
|
two lines for me
edit: no, I am not zoomed out 😅 |
|
very strange, keep the commas then. |
ctcpip
force-pushed
the
history-example
branch
2 times, most recently
from
bce81cd to
06c5f39
Compare
ljharb
reviewed
Feb 15, 2024
ctcpip
force-pushed
the
history-example
branch
from
06c5f39 to
12c00b8
Compare
christceder
approved these changes
May 17, 2024
ljharb
force-pushed
the
history-example
branch
5 times, most recently
from
c4faec2 to
e8bd86c
Compare
ljharb
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.