Debug IDs: Only allow Debug IDs in the canonical UUID format #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase? :) |
nicolo-ribaudo
approved these changes
Nov 15, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 15, 2024
SHA: f768429 Reason: push, by nicolo-ribaudo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #141
This proposal change may be a bit controversial.
I am suggesting to limit Debug IDs within Source Maps and generated files to be in a specific format - specifically the canonical UUID format (e.g.
85314830-023f-4cf1-a267-535f4e37bb17)This is for the very simple reason of ensuring compatibility, consistency and simplicity in the ecosystem.
Drawbacks are:
Would be great to have some feedback and discussions around this!