Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deliver initial crawler payload #236

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

DerekNonGeneric
Copy link
Contributor

No description provided.

@DerekNonGeneric DerekNonGeneric force-pushed the update-stage-3/2021-01-02 branch from b3d1a72 to bbdf199 Compare January 2, 2021 21:36
_data/stage3.yml Outdated Show resolved Hide resolved
_data/stage3.yml Outdated Show resolved Hide resolved
@codehag
Copy link
Collaborator

codehag commented Jan 4, 2021

Please update the title of this pr so it is more descriptive, and address the issue with the manually added information being lost. See #211 (comment) regarding this issue with the crawler.

@DerekNonGeneric DerekNonGeneric changed the title ⬆️3️⃣ January 2021 update stage 3️⃣ proposal data for January 2021 Jan 4, 2021
_data/stage3.yml Outdated Show resolved Hide resolved
@DerekNonGeneric DerekNonGeneric force-pushed the update-stage-3/2021-01-02 branch from c143345 to ad2f46f Compare January 5, 2021 02:40
@DerekNonGeneric DerekNonGeneric changed the title update stage 3️⃣ proposal data for January 2021 ⬆️3️⃣ update stage 3 proposal data for January 2021 Jan 5, 2021
@DerekNonGeneric DerekNonGeneric changed the title ⬆️3️⃣ update stage 3 proposal data for January 2021 ℹ️⬆️ update stage 3 proposal data for January 2021 Jan 5, 2021
@DerekNonGeneric
Copy link
Contributor Author

Titles purposely not “update stage 3 January 2021” due to there being a date format that looks like DD Month YYYY, which could end up looking like January 3rd, 2021. Will have to settle on something once these become automated, though.

@codehag
Copy link
Collaborator

codehag commented Jan 5, 2021

A better title here would be something to the effect of "automated update of notes links" or "automated update of notes links for November 2020", as that is what this is doing. The date "January 2021" is misleading in a few ways. We will have a meeting in January 2021, but this commit doesn't have anything to do with it. The second is that this date information in this commit isn't important, as we already have that information in the commit itself.

Regarding the automation commit messages -- since you are suggesting this is automatically generated. if you are creating automated commits please remove the emojis, it isn't clear what they mean. I am not sure what i and up mean here, but it seems now like you were intending to say that "this was automated". In general I would recommend against using emojis to convey information, as they are very confusing and have multiple interpretations.

@DerekNonGeneric DerekNonGeneric changed the title ℹ️⬆️ update stage 3 proposal data for January 2021 deliver initial crawler payload Jan 5, 2021
@DerekNonGeneric DerekNonGeneric force-pushed the update-stage-3/2021-01-02 branch from ad2f46f to 8f3cabb Compare January 6, 2021 00:12
* add code tags to regexp-legacy-features description
* add curly quotes to atomics-wait-async description
* use existing relative-indexing-method example
@DerekNonGeneric DerekNonGeneric force-pushed the update-stage-3/2021-01-02 branch from 8f3cabb to 0fb33ed Compare January 6, 2021 16:33
@codehag codehag merged commit 3021176 into tc39:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants