Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a little helper for convenience in testing changes #1260

Merged
merged 3 commits into from
Oct 4, 2017

Conversation

caitp
Copy link
Contributor

@caitp caitp commented Oct 4, 2017

I split this out of #1250. I think it's a nice thing to have, as it makes it very easy
to test changes in VMs before submitting them to test262.

A more portable version would be nice, but this is tested and working well on OSX and
the windows linux subsystem, which is good enough for me.

;;
--head)
# Add test files changed since the last commit
files+=( "$( git diff HEAD --name-only | grep "^test/" )" )
Copy link
Contributor

@azz azz Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add --diff-filter=d to exclude files deleted since the revision?

Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't have a direct use for these, this can't hurt the tests or anything. Most of the use case here I generally roll with git diff calls.

I'm +1 to land it, LGTM.

@leobalter leobalter merged commit b006e1c into tc39:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants