Tests for String.prototype.matchAll #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`String.prototype.matchAll`: Add basic tests.
`RegExp.prototype[Symbol.matchAll]`: Add basic tests.
…matchall], and %RegExpStringIteratorPrototype% Tests were updated and assuming tc39/proposal-string-matchall#33 will be merged.
|
ping @rwaldron @leobalter :-) |
Ready to go then? |
|
Yes, i think so! There’s still tc39/proposal-string-matchall#34, but I’ll file any update PRs here if there’s changes as a result. |
rwaldron
approved these changes
Apr 11, 2018
| # String.prototype.matchAll | ||
| # https://github.com/tc39/proposal-string-matchall | ||
| String.prototype.matchAll | ||
| Symbol.matchAll |
28 tasks
gsathya
reviewed
Jun 6, 2018
| This property has the attributes { [[Writable]]: false, [[Enumerable]]: | ||
| false, [[Configurable]]: false }. | ||
| includes: [propertyHelper.js] | ||
| features: [Symbol.match] |
There was a problem hiding this comment.
@gsathya Thanks, this is already being corrected with this PR (that is updating to the latest spec changes): https://github.com/tc39/test262/pull/1587/files#diff-dcc8c9cf15ec70a98b42af64c99e751d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.prototype.matchAllis at stage 3.Here's the tests for it; with help from @peterwmwong / ljharb#1.
Please do not merge this yet; there's still a few unresolved issues on the proposal repo and I'd rather update the PR in-place if there ends up being changes :-)