Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for ECMA262 #2216 #2878

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Update tests for ECMA262 #2216 #2878

merged 1 commit into from
Feb 26, 2021

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Oct 27, 2020

@devsnek devsnek mentioned this pull request Oct 27, 2020
Merged
@rwaldron
Copy link
Contributor

I'll take a look at this and the related PR tomorrow—thanks!

@devsnek devsnek dismissed a stale review via f160c2c October 27, 2020 23:24
@devsnek devsnek force-pushed the default-constructor-refactor branch from 73dd91b to f160c2c Compare October 27, 2020 23:24
@rwaldron rwaldron added awaiting specification awaiting consensus This needs committee consensus before it can be eligible to be merged. and removed awaiting specification labels Oct 28, 2020
@rwaldron
Copy link
Contributor

@devsnek now that this has consensus, is it ready to merge?

@rwaldron rwaldron added the has consensus This has committee consensus label Nov 18, 2020
@devsnek
Copy link
Member Author

devsnek commented Nov 18, 2020

It should be.

@rwaldron rwaldron removed the awaiting consensus This needs committee consensus before it can be eligible to be merged. label Nov 18, 2020
@ljharb
Copy link
Member

ljharb commented Feb 24, 2021

@rwaldron can this land? test262 tests are intended to land before the spec PR.

@rwaldron
Copy link
Contributor

@ljharb There's an unaddressed question from @ExE-Boss

@devsnek devsnek force-pushed the default-constructor-refactor branch from f160c2c to 6e2c41c Compare February 25, 2021 16:46
@ljharb ljharb requested a review from rwaldron February 26, 2021 05:57
@rwaldron
Copy link
Contributor

Thanks everyone!

@rwaldron rwaldron merged commit 516ca9a into tc39:main Feb 26, 2021
@bakkot bakkot mentioned this pull request May 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExE-Boss ExE-Boss ExE-Boss left review comments

@rwaldron rwaldron rwaldron approved these changes

Assignees

@devsnek devsnek

Labels
has consensus This has committee consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devsnek @rwaldron @ljharb @ExE-Boss