Draft: RFC process documentation #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
previously approved these changes
May 12, 2022
ljharb
reviewed
May 12, 2022
ptomato
added
valid and in progress
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Nov 16, 2022
This proposes a `harness/asyncHelpers.js` file with two helpers in it, `asyncTest()` and `assert.throwsAsync()`. See the RFC for further motivation and details. Note the draft RFC process in tc39#3525. My idea for this pull request is that besides being an RFC in its own right, we use it as a test case for the process. That is, we follow the draft RFC process and hopefully either validate it, or surface changes that need to be made, after which we can land the RFC process in our documentation.
Merged
ptomato
added a commit
that referenced
this pull request
Jan 20, 2023
This proposes a `harness/asyncHelpers.js` file with two helpers in it, `asyncTest()` and `assert.throwsAsync()`. See the RFC for further motivation and details. Note the draft RFC process in #3525. My idea for this pull request is that besides being an RFC in its own right, we use it as a test case for the process. That is, we follow the draft RFC process and hopefully either validate it, or surface changes that need to be made, after which we can land the RFC process in our documentation.
ptomato
commented
Jan 20, 2023
There was a problem hiding this comment.
Now that we've had one RFC land, does anyone have any feedback on the process? I've added some specific feedback from myself as review comments.
As for general feedback, I think the process is a bit on the heavy side for the harness modification that we did. I wonder if we can adjust things so that the amount of effort is proportional to the disruptiveness of the change.
|
I've updated the process document based on our discussion in this week's maintainers meeting, please have a look! (I've kept the changes in a separate commit so it's easy to see what's new.) It would be nice to be able to merge this on Monday so we can announce in our TC39 status update that it's done. |
jugglinmike
approved these changes
Feb 15, 2023
This is a process allowing contributors to submit well-motivated proposals to improve test262 using an RFC (Request For Commments) process which is adapted from a similar process in the Rust community.
ljharb
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a process allowing contributors to submit well-motivated
proposals to improve test262 using an RFC (Request For Commments)
process which is adapted from a similar process in the Rust community.