Temporal: Tests for date difference algorithm #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2024
Ms2ger
approved these changes
Feb 9, 2024
This adds tests specifically for every kind of case that changes due to the tweak to the date difference algorithm: differences from a longer month to a shorter month, when the months are adjacent, in the same year but not adjacent, and in different years. Also adds tests for a case that does *not* change, but would trip on an incorrectly implemented algorithm: when the intermediate months value falls at the end of February. There was incidental coverage of the change to the date difference algorithm in other tests. Those are adjusted, as well. Normative change: tc39/proposal-temporal#2759 Consensus in February 2024
ptomato
force-pushed
the
temporal-2535-end-of-month-edge-cases
branch
from
6815174 to
406d51b
Compare
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests specifically for every kind of case that changes due to the tweak to the date difference algorithm: differences from a longer month to a shorter month, when the months are adjacent, in the same year but not adjacent, and in different years.
Also adds tests for a case that does not change, but would trip on an incorrectly implemented algorithm: when the intermediate months value falls at the end of February.
There was incidental coverage of the change to the date difference algorithm in other tests. Those are adjusted, as well.
Normative change: tc39/proposal-temporal#2759
Consensus in February 2024