Skip to content

Conversation

@dminor
Copy link
Contributor

@dminor dminor commented Apr 15, 2025

These tests are currently being executed in SpiderMonkey as non262 tests, and were exported using the test262-export.py script. Linting errors were then corrected.

These tests are currently being executed in SpiderMonkey as `non262` tests,
and were exported using the `test262-export.py` script. Linting errors
were then corrected.
@dminor dminor requested review from a team as code owners April 15, 2025 13:38
@dminor dminor mentioned this pull request Apr 14, 2025
17 tasks
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is staging, so you should feel free to (and already have the appropriate permissions to) commit these as long as they are executable by other engines' test262 harnesses.

That said, I suspect they will not pass in any other engines unless you add includes: [sm/non262.js, sm/non262-shell.js] to each one.

Optionally, there's also some low-hanging fruit that could make them slightly more ready to move out of staging when the time comes:

  • Add a feature for the upsert proposal to features.txt and add it to features in the frontmatter of each test
  • Use verifyProperty instead of assert.deepEqual(Object.getOwnPropertyDescriptor(...etc))
  • Use assert.throws(ExceptionType, function () { ... }) instead of assertThrowsInstanceOf(function () { ... }, ExceptionType)

@dminor
Copy link
Contributor Author

dminor commented Apr 24, 2025

Thanks for the suggestions on how to fix these up, I'll look into that next week prior to committing.

@nicolo-ribaudo
Copy link
Member

Remove cross-compartment tests

I haven't seen it tested before in test262, but if you want you could restore those tests using $262.createRealm().evalScript.

@dminor dminor requested a review from ptomato May 5, 2025 17:44
@dminor
Copy link
Contributor Author

dminor commented May 5, 2025

@ptomato Hi Philip, I've addressed your suggestions and checked that the tests pass in engine262 (with my upsert PR) and SpiderMonkey. I don't have permissions to commit this, could you please have another look and if looks ok, commit it?

@ptomato
Copy link
Contributor

ptomato commented May 5, 2025

Sure thing. I didn't review these for completeness, just gave them a quick glance and executed them.

I found it puzzling that you didn't have permission to land this but then I realized it's because of the change to features.txt. My bad; I should have done that in a separate PR, then you would have been able to merge this yourself whenever it was ready. Sorry about that.

@ptomato ptomato merged commit 93d6396 into tc39:main May 5, 2025
11 checks passed
@dminor
Copy link
Contributor Author

dminor commented May 5, 2025

No problem, thank you for the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants