-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom adaptor tutorial example #66
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 62 62
Lines 2045 2045
=======================================
Hits 1998 1998
Misses 47 47 ☔ View full report in Codecov by Sentry. |
@jnytra If you can, would you mind looking through this tutorial/example and letting me know if anything is unclear or doesn't make sense? |
This is absolutely amazing. This is exactly what I needed to write a new adaptor. I don't have any comments yet, but I plan to write a new adaptor according to this tutorial, so I'll see. |
@jnytra Sounds good! If you're planning to add any new adaptors or algorithms please file an issue first (I'll mark it as an enhancement and assign you to "fix" it) so that we don't end up working on the same thing :) |
* convenient. | ||
*/ | ||
|
||
struct flux_sequence_traits { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to struct flux_sequence_traits : flux::default_sequence_traits {
This tutorial is great, it's exactly what I needed to get started. One issue I ran into is that struct flux_sequence_traits { to struct flux_sequence_traits : flux::default_sequence_traits { resolves the issue. I can't add a commit to this pr, but I didn't think that this change warranted a completely new pull request. Thanks again for the tutorial! |
No description provided.