Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Modified config to support read more tags and posts limitations #203

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

vish-rt
Copy link
Contributor

@vish-rt vish-rt commented Aug 27, 2023

Fixing the updated issue #108, the following things were accomplished:

  1. Added a limitation to the blogs visible on the page to see only 3 posts per page, to avoid a clutter of blogs.
  2. Implemented the use of <!--truncate--> tag to cut down the blog overflow and add a "Read More" tag to one blog.
  3. Added a Regular Expression to identify truncate tags in .mdx files, absence of which would throw a compilation error.

Screenshots to support above fixes:

  1. After every third blog, a button to view past blogs will be visible
    image

  2. In the following blog, only a small portion is visible on the blogs page, prompting user to open the blog to read further
    image

Note: On GitHub Pull Request Preview, the truncate tag would be highlighted in red, indicating error in the file's syntax. It is solely because GitHub does not use Docusaurus' config to run a compilation. However upon running npm run build, we have a build success, indicating no errors and a proper deployment.

@vish-rt vish-rt linked an issue Aug 27, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview Aug 27, 2023 4:55pm

@netlify
Copy link

netlify bot commented Aug 27, 2023

Deploy Preview for tect-opensource-documentation ready!

Name Link
🔨 Latest commit 5f88eea
🔍 Latest deploy log https://app.netlify.com/sites/tect-opensource-documentation/deploys/64eb8018e8f0270008443a22
😎 Deploy Preview https://deploy-preview-203--tect-opensource-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vish-rt
Copy link
Contributor Author

vish-rt commented Aug 27, 2023

All checks passed with deployment preview for the same. Recommend having a look to witness my artwork.

Do note that the changes mentioned in the issue have only been applied to ONE blog only. Might be a good idea to create another issue to keep track of converting all blogs in the set standard.

@vish-rt vish-rt requested a review from NikitaSShukla August 27, 2023 16:59
Copy link
Member

@himanshu-03 himanshu-03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@demonkillerr demonkillerr added the bug Something isn't working label Aug 27, 2023
Copy link
Member

@demonkillerr demonkillerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@@ -57,6 +57,8 @@ const config = {
blogTitle: "Blogs",
blogDescription: "TCET Open Source Blogging Page",
blogSidebarCount: 'ALL',
postsPerPage: 3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to revise this in the future, as I believe we have around 10 entries on the sidebar

@demonkillerr demonkillerr merged commit b52cbff into main Aug 27, 2023
@himanshu-03 himanshu-03 deleted the 108_social_card branch August 31, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Social Card to all Blogs
3 participants