Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign Tchap to Universal Links changes from Element iOS #639

Closed
phloux opened this issue Jul 28, 2022 · 2 comments
Closed

Realign Tchap to Universal Links changes from Element iOS #639

phloux opened this issue Jul 28, 2022 · 2 comments
Assignees
Labels

Comments

@phloux
Copy link

phloux commented Jul 28, 2022

As seen with the last rebase (1.8.20), there is some changes to the Universal Links management in Element iOS.

We also saw that Element iOS need a fix to the method definition - (BOOL)handleUniversalLinkFragment:(NSString*)fragment fromURL:(NSURL*)universalLinkURL in header file. This method has been renamed - (BOOL)handleUniversalLinkFragment:(NSString*)fragment fromLink:(UniversalLink*)universalLink in the implementation file.
And I think it's the source of the bug mentioned here : element-hq/element-ios#6492

@phloux phloux added the iOS label Jul 28, 2022
@phloux phloux changed the title Realign Tchap to Universal Links changes in Element iOS Realign Tchap to Universal Links changes from Element iOS Jul 28, 2022
@pixlwave
Copy link
Contributor

pixlwave commented Aug 3, 2022

@phlniji There's a PR to fix those now open on Element iOS: element-hq/element-ios#6522

@giomfo
Copy link
Contributor

giomfo commented Aug 18, 2022

@phlniji I will let you close this issue when everything will be ok (depend on the next rebase)

@giomfo giomfo closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants