Fix an infinite loop when tapping an unjoined room alias.

[pixlwave]

When tapping on an unjoined room alias, the app delegate would look up the room ID for it, but as the link wasn't updated when it attempted to handle the new fragment the look up was made again.

Fixes #6492.

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/d6sSbf

[codecov-commenter]

Codecov Report

Merging #6522 (f398c7f) into develop (c9e916b) will decrease coverage by 0.00%.
The diff coverage is 24.32%.

@@             Coverage Diff             @@
##           develop    #6522      +/-   ##
===========================================
- Coverage     6.20%    6.19%   -0.01%     
===========================================
  Files         1462     1462              
  Lines       157168   157179      +11     
  Branches     63166    63164       -2     
===========================================
- Hits          9745     9741       -4     
- Misses      147014   147031      +17     
+ Partials       409      407       -2     

Impacted Files	Coverage Δ
Riot/Modules/Application/LegacyAppDelegate.m	13.33% <0.00%> (-0.31%)	⬇️
...iot/Modules/Common/Recents/RecentsViewController.m	8.17% <0.00%> (+0.16%)	⬆️
...Modules/Communities/Home/GroupHomeViewController.m	0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m	0.00% <0.00%> (ø)
...SharingViewer/View/LiveLocationSharingViewer.swift	0.00% <0.00%> (ø)
Riot/Utils/UniversalLink.m	60.80% <42.85%> (-5.87%)	⬇️
...iewControllerWithBannerWrapperViewController.swift	46.91% <100.00%> (+2.04%)	⬆️
Config/CommonConfiguration.swift	85.71% <0.00%> (-5.20%)	⬇️
Riot/Managers/Call/CallPresenter.swift	1.08% <0.00%> (-5.14%)	⬇️
...rs/EncryptionKeyManager/EncryptionKeyManager.swift	35.41% <0.00%> (-4.17%)	⬇️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ef5c3...f398c7f. Read the comment docs.

[ismailgulek]

Couple of suggestions. Would like to hear if those make sense. Otherwise LGTM!

[pixlwave]

Yep, all 3 make sense to me. Thank for the suggestions, I hadn't thought about doing it like that 👍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[ismailgulek]

LGTM!