Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chiffrement : sur web la barre de "déchiffrement" ne s'affiche plus #793

Closed
odelcroi opened this issue Oct 30, 2023 · 5 comments
Closed
Labels
bug Something isn't working P1 Priority 1 regression - caused by update web

Comments

@odelcroi
Copy link
Member

odelcroi commented Oct 30, 2023

Steps to reproduce

  1. write messages on a private room
  2. disconnect
  3. connect
  4. go to private room
  5. messages are locked, will not be unlocked

Outcome

When messages are locked, the client tries to unlock them. A status bar is displayed on the top bar of the room. This one : #495

But nothing is displayed

image

Impacts

Les mécanismes liées aux chiffrements apportent de la confusion. Cette top bar permet d'expliquer à l'utilisateur ce qu'il se passe et permet de renvoyer vers la FAQ.

@odelcroi odelcroi added bug Something isn't working web P1 Priority 1 labels Oct 30, 2023
@odelcroi odelcroi changed the title La barre de déchiffrement ne s'affiche plus chiffrement : la barre de "déchiffrement" ne s'affiche plus Oct 31, 2023
@odelcroi odelcroi changed the title chiffrement : la barre de "déchiffrement" ne s'affiche plus chiffrement : sur web la barre de "déchiffrement" ne s'affiche plus Oct 31, 2023
@estellecomment
Copy link
Contributor

Actuellement la tchap translation est tjs la, mais le code est parti.

  • retrouver à quelle upgrade d'element ca a disparu
  • retrouver la PR d'element qui l'a supprimé, et pourquoi

@estellecomment
Copy link
Contributor

PR : Remove DecryptionFailureBar : matrix-org/matrix-react-sdk#11027
In element-web 1.11.34, which Tchap got by upgrading 1.11.30 -> 1.11.39, released in tchap-4.3.8

Why : "it does not really provide any more benefit to users."
element-hq/element-meta#1358 (comment)

@estellecomment
Copy link
Contributor

Decryption bar was added in element-web 1.11.18.
Tchap got it in tchap-4.2.0-1.11.25

@estellecomment
Copy link
Contributor

estellecomment commented Oct 31, 2023

Whatsapp fait ca pour info :
image

Le message "attends un peu tout va bien" est bcp mieux que "impossible de deverrouiller". Il suffirait de changer de string.
Edit : filed in tchapgouv/tchap-product#221

@estellecomment
Copy link
Contributor

I don't think element will re-add something they voluntarily removed.
I don't really want to re-add it in a patch and have to maintain something tricky (element had a lot of problems with it, that's why they removed it)
So I'm not really going to do anything here.

We could open an issue in element-web if we have a simpler need that could be adressed? I don't know.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Priority 1 regression - caused by update web
Projects
Archived in project
Development

No branches or pull requests

2 participants