Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sso): add email domain precheck sso flow #1111

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

MarcWadai
Copy link
Contributor

@MarcWadai MarcWadai commented Sep 19, 2024

fixes #1094

Changes

  • New welcome page
    image

  • new email check page
    image

  • New feature flag to activate the view of this flow or not :

tchap_sso_flow: {
  isActive: true
}
  • New register page
    image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@MarcWadai MarcWadai force-pushed the 386-sso-agentconnect-flow branch 2 times, most recently from c89dc2c to 867d274 Compare September 26, 2024 10:09
@MarcWadai MarcWadai marked this pull request as ready for review September 26, 2024 15:24
@MarcWadai MarcWadai force-pushed the 386-sso-agentconnect-flow branch 5 times, most recently from 557b499 to 390d1a6 Compare October 2, 2024 17:21
Copy link
Contributor Author

@MarcWadai MarcWadai Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests on this file are not actually working. There is one mock that have difficulties to be taken into account (registerrequest) ... The correct behavior is that this method will be called and should return 401 Matrix error (if not UIA action), and then show the different component of the registration. However, the mock written for it is bypassed and I couln't figure it out yet.
I am still leaving it like this, because the other part should be correct, and if one day i have the illumination to solve it, it will be here :D

@MarcWadai MarcWadai merged commit 5ca89ce into develop_tchap Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AgentConnect : ne montrer le bouton "continuer avec Agent Connect" qu'une fois l'email saisi (web)
1 participant