Upgrade/element web v1.11.44 #763

estellecomment · 2023-10-09T08:19:29Z

Fixes #734

TODO

fix conflicts
patches
- better-help-settings-2 : reimplement it's too complicated to understand.
- registration-for-mainlining : not sure what happened, probly start over
ci
- linter
- tests : enzyme error. Is it time to remove enzyme like reactsdk ?
- cypress : settings.spec.ts is broken by translation problem.

Extra things to think about and do

translations are frozen, halfway through transitioning to another translation system. Are they all broken ? Partly. Transformation en module de la traduction de l'app #703
translations now are organized into nested categories which is nice. Should we do this too ? Now or later ? -> later. Too much stuff already
manual tests
- better-help-settings-2 : run /rageshake and check dialog -> Small regression. Fix it or leave it ?
- the checklist for version upgrades : Plan de test pour upgrade 1.11.44 #768
checkboxes in the issue
couleur des avatars pétée, c'est moins lisible qu'avant -> filed Colors of avatars are broken (after upgrade 1.11.14) #772, will solve after this PR
all the languages came back, delete them. They populate the dropdown for chosing the language, it's too noisy. -> added a patch to filter out languages. That way we leave the language files alone.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…680)

* Update all non-major dependencies * Roll back typescript --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

…-analytics-events (#25712)

Bumps [stylelint](https://github.com/stylelint/stylelint) from 15.9.0 to 15.10.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@15.9.0...15.10.1) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…5725)

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

…ixing.

estellecomment · 2023-10-09T13:36:51Z

Petite regression du dialog de /rageshake. (est-ce que ca vaut le coup de la fixer ? Ajouté dans la checklist)

Expected :

Obtained :

estellecomment · 2023-10-09T13:38:30Z

couleur des avatars pétée, c'est moins lisible qu'avant. (ajouté à la checklist dans la PR description)

Expected :

Obtained :

Edit : this is filed already in element-web : element-hq/element-web#26285, on 13 sep. No news.

estellecomment · 2023-10-09T13:42:28Z

translations : key format has changed, so many translations are broken in our customisations files.

-> filed #769, will fix after this PR is merged.
Edit : actually now its #703

…t has extra character

estellecomment · 2023-10-10T12:36:18Z

Translation situation : translation keys are in the process of changing format : "Secure Backup" -> "common|secure_backup". Some keys are already migrated, some are not.

The new format is not custom-translateable with our current setup (tchap-translations.json doesn't work). So for 1.11.44 part of our custom translations disappear. For the next upgrade they will probably all disappear !

Issue already filed, we need to make a module : #703

…ss future patch breaks.

.github/workflows/build_debian.yaml

.github/workflows/dockerhub.yaml

patches/cross-signing-ui/matrix-react-sdk+3.81.0.patch

odelcroi · 2023-10-13T07:47:39Z

patches/cross-signing-ui/matrix-react-sdk+3.81.0.patch

 +            // :tchap: return _t("Continue");
-+            return _t("Activate");
+             return _t("action|continue");


should be Activate?

another good catch !

Ma conclusion c'est qu'on devrait e2e tester les custom translations 🤔
On pourrait utiliser des snapshots. J'aime pas trop les snapshots parce qu'ils cassent dès que le moindre bout de html change, ce qui arrive hors-bug.
Sinon on code des tests de translations... Ou une sorte de snapshots flexibles, je sais pas si ca existe... 🤔

Filed #785

…icts fixed, not tested yet)

…test)

…n of new-style is not possible yet.

renovate bot and others added 30 commits June 27, 2023 12:26

Update docker/setup-buildx-action digest to ecf9528 (#25586)

8b481fd

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update docker/login-action digest to 465a078 (#25584)

9be30a8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update docker/setup-qemu-action digest to 2b82ce8 (#25587)

cd3a88e

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

Update peter-evans/dockerhub-description digest to dc67fad (#25671)

51baaf6

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

remove auth params from url after login attempt (#25664)

6bbc2b8

Conform more of the codebase to strictNullChecks & noImplicitAny (#25…

0299aef

…680)

Update all non-major dependencies (#25588)

4f1ce3c

* Update all non-major dependencies * Roll back typescript --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

Align develop.e.io cloudflare pages headers with other deploys (#25700)

7164aeb

Upgrade matrix-react-sdk to 3.75.0

53ac1d1

Upgrade matrix-js-sdk to 26.2.0

eec9543

Prepare changelog for v1.11.35

aa55a2f

v1.11.35

c286617

Merge branch 'master' into develop

ab158ce

Reset matrix-react-sdk back to develop branch

210a8ee

Reset matrix-js-sdk back to develop branch

faa602d

Tweak branch matching to allow not applying outside of PRs for matrix…

d31a498

…-analytics-events (#25712)

Update matrix-react-sdk yarn.lock

01a234a

Enable strictNullChecks and noImplicitAny (#25724)

658e282

Enable strictPropertyInitialization (#25729)

fad458d

Enable strictFunctionTypes (#25730)

6726b93

Enable strictPropertyInitialization (#25735)

0a4a205

Deprecate customisations in favour of Module API (#25736)

bac0da3

Bump tough-cookie from 4.1.2 to 4.1.3 (#25743)

9ec3f79

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Allow default_server_config as a fallback config (#25682)

93c1710

Utility automation for updating topics as part of release process (#2…

ccb0a30

…5725)

Update update-topics.yaml

a4eb2f4

Add default_server_config fallback to element.io configs (#19695)

98e36ff

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

Update update-topics.yaml

9610326

Update update-topics.yaml

71ab304

estellecomment added 2 commits October 9, 2023 15:19

Disable static analysis jobs that are broken. Issue opened to track f…

b9a2967

…ixing.

Run prettier on webpack.config.js. Only whitespace changes.

91f7189

estellecomment mentioned this pull request Oct 9, 2023

Plan de test pour upgrade 1.11.44 #768

Closed

20 tasks

estellecomment added 3 commits October 10, 2023 13:49

Restore setupTests.ts in jestconfig, needed for enzyme

04c299d

Fix strings in TchapCreateRoomDialog.tsx (fixes cypress test)

9996c27

Fix export-room-members cypress test : matrix id for recreated accoun…

5fa658a

…t has extra character

Refactor patch better-help-settings-2 to be more readable and have le…

61082e1

…ss future patch breaks.

odelcroi reviewed Oct 13, 2023

View reviewed changes

estellecomment added 2 commits October 16, 2023 10:47

Fix merge error

f7f6832

Fix merge regression, and reuse existing translation

094c0c0

estellecomment closed this Oct 16, 2023

estellecomment reopened this Oct 16, 2023

estellecomment added 5 commits October 17, 2023 11:49

Add patch to filter languages

3f67d21

Merge branch 'develop_tchap' into upgrade/element-web-v1.11.44 (confl…

e6b717c

…icts fixed, not tested yet)

Upgrade translations on registration patch

e4517a6

Update translations in patches

9fc7d98

Update translations for Help user settings

576f48b

estellecomment closed this Oct 27, 2023

estellecomment reopened this Oct 27, 2023

estellecomment added 2 commits October 27, 2023 15:06

Attempt custom-translating a new-format string (and fix settings e2e …

cb31dd6

…test)

Merge branch 'develop_tchap' into upgrade/element-web-v1.11.44

a23b8dd

estellecomment added upgrade P1 Priority 1 labels Oct 31, 2023

estellecomment added 2 commits November 2, 2023 10:03

Merge branch 'develop_tchap' into upgrade/element-web-v1.11.44

2f8dc36

Revert a new-style translation to the old style, because customisatio…

ca47bf6

…n of new-style is not possible yet.

estellecomment merged commit 47f5c81 into develop_tchap Nov 2, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade/element web v1.11.44 #763

Upgrade/element web v1.11.44 #763

estellecomment commented Oct 9, 2023 •

edited

Loading

estellecomment commented Oct 9, 2023 •

edited

Loading

estellecomment commented Oct 9, 2023 •

edited

Loading

estellecomment commented Oct 9, 2023 •

edited

Loading

estellecomment commented Oct 10, 2023

odelcroi Oct 13, 2023

estellecomment Oct 16, 2023

Upgrade/element web v1.11.44 #763

Upgrade/element web v1.11.44 #763

Conversation

estellecomment commented Oct 9, 2023 • edited Loading

estellecomment commented Oct 9, 2023 • edited Loading

estellecomment commented Oct 9, 2023 • edited Loading

estellecomment commented Oct 9, 2023 • edited Loading

estellecomment commented Oct 10, 2023

odelcroi Oct 13, 2023

Choose a reason for hiding this comment

estellecomment Oct 16, 2023

Choose a reason for hiding this comment

estellecomment commented Oct 9, 2023 •

edited

Loading

estellecomment commented Oct 9, 2023 •

edited

Loading

estellecomment commented Oct 9, 2023 •

edited

Loading

estellecomment commented Oct 9, 2023 •

edited

Loading