Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Combined Docker image #150

Merged
merged 8 commits into from
May 31, 2024
Merged

[Feature] Combined Docker image #150

merged 8 commits into from
May 31, 2024

Conversation

tchapi
Copy link
Owner

@tchapi tchapi commented Mar 4, 2024

  • combined Docker image with Caddy, supervisord, PHP-fpm
  • new workflow to build both flavours of the image (davis, davis-standalone)

@tchapi tchapi self-assigned this Mar 4, 2024
@tchapi tchapi added the enhancement New feature or request label Mar 4, 2024
@tchapi tchapi changed the title [Feature] Combined image [Feature] Combined Docker image Mar 4, 2024
@tchapi tchapi force-pushed the feature/combined-docker-image branch 5 times, most recently from 93de736 to 5d6948e Compare March 16, 2024 19:43
@tchapi tchapi force-pushed the feature/combined-docker-image branch from 5d6948e to eaac75f Compare March 22, 2024 11:29
@tchapi tchapi force-pushed the feature/combined-docker-image branch 2 times, most recently from feeb879 to 1b223b2 Compare April 1, 2024 21:54
@Ramblurr
Copy link
Contributor

Ramblurr commented Apr 2, 2024

FWIW I have an all-in-one davis image (nginx, phpfpm, davis) over here. Though I'll be retiring it soon as I move from a container deployment to NixOS. Feel free to yoink anything if you want.

@tchapi
Copy link
Owner Author

tchapi commented Apr 2, 2024

Thanks for the pointers. Do you have a TL,DR of the improvements you made (apart from adding the reverse-proxy in there), that would be helpful to bake into a common standalone image?

@Ramblurr
Copy link
Contributor

Ramblurr commented Apr 2, 2024

Things I added that I think are worthwhile are:

  • the opcache settings for a perf boost
  • php fpm tuning settings
    • www.conf
    • in particular the pm.max_children I had to raise from whatever the default was because when I migrated to davis and did a full sync from my old provider it ran out of children and stalled the sync process.

@tchapi tchapi force-pushed the feature/combined-docker-image branch from 1b223b2 to af44f6a Compare May 14, 2024 21:16
@tchapi tchapi force-pushed the feature/combined-docker-image branch from af44f6a to f059e5d Compare May 19, 2024 21:17
@tchapi tchapi merged commit c385629 into main May 31, 2024
4 checks passed
@tchapi tchapi deleted the feature/combined-docker-image branch May 31, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants