-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra information to nodes page - controller status, partition load #983
Comments
PR are welcome on that,
|
I made a pull request, I am neither a reactjs developer nor a java developer, so you will hopefully excuse the poor code. I think the controller status was successfully added. The partition information I could not figure out yet (some advice would be welcome). Also I could not figure out how to add a second docker container to the dev environment and have it join the Kafka cluster so that I could properly test the controller output. I tried editing the docker "docker-compose-dev.yml" but no matter what I tried the new container would not join properly |
relate to #983 Co-authored-by: Ludovic DEHON <tchiot.ludo@gmail.com>
so i see you have merged the controller status in. I will next tackle the partition information, now @tchiotludo has clarified that it needs back end updates. |
I am struggling a little bit to figure out where in the backend java code I need to insert the code to fetch the partition information so that it can be included in the info passed to the /nodes page. Can anyone provide some guidance? |
After some more looking through the code, it is apparent that somehow the NodeController needs access to the topic repository, but it is un clear to me how this can happen |
You need to inject topic repository : @Inject
TopicRepository topicRepository and add some filtering on partitions based on node id |
There is now a pull request to add the additional "partitions" column. Code is functional as far as I can test (I don't know how to join a second node to the Kafka cluster in docker). Comments are welcome, especially given this is my first time contributing Java code. |
Any chance the following extra information could be added to the nodes page?
Having the controller status and the partition load (% of total), is very helpful to see when the cluster has stabilized post reboot.
The text was updated successfully, but these errors were encountered: