Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra information to nodes page - controller status, partition load #983

Closed
jgrammen-agilitypr opened this issue Jan 18, 2022 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers node Kafka Node

Comments

@jgrammen-agilitypr
Copy link
Contributor

Any chance the following extra information could be added to the nodes page?

image

Having the controller status and the partition load (% of total), is very helpful to see when the cluster has stabilized post reboot.

@jgrammen-agilitypr
Copy link
Contributor Author

maybe the node page could also indicate when a node is missing:
image

@tchiotludo tchiotludo added the enhancement New feature or request label Jan 26, 2022
@tchiotludo
Copy link
Owner

tchiotludo commented Jan 26, 2022

PR are welcome on that,

  • 1st is a simple ui.
  • 2nd seems to be more complicated (I don't know if the api return the value)

jgrammen-agilitypr added a commit to jgrammen-agilitypr/akhq that referenced this issue Jan 27, 2022
@jgrammen-agilitypr
Copy link
Contributor Author

I made a pull request, I am neither a reactjs developer nor a java developer, so you will hopefully excuse the poor code. I think the controller status was successfully added. The partition information I could not figure out yet (some advice would be welcome). Also I could not figure out how to add a second docker container to the dev environment and have it join the Kafka cluster so that I could properly test the controller output. I tried editing the docker "docker-compose-dev.yml" but no matter what I tried the new container would not join properly

tchiotludo added a commit that referenced this issue Jan 27, 2022
relate to #983

Co-authored-by: Ludovic DEHON <tchiot.ludo@gmail.com>
@jgrammen-agilitypr
Copy link
Contributor Author

so i see you have merged the controller status in. I will next tackle the partition information, now @tchiotludo has clarified that it needs back end updates.

@jgrammen-agilitypr
Copy link
Contributor Author

I am struggling a little bit to figure out where in the backend java code I need to insert the code to fetch the partition information so that it can be included in the info passed to the /nodes page. Can anyone provide some guidance?

@jgrammen-agilitypr
Copy link
Contributor Author

After some more looking through the code, it is apparent that somehow the NodeController needs access to the topic repository, but it is un clear to me how this can happen
any advice?

@tchiotludo tchiotludo added good first issue Good for newcomers node Kafka Node labels Feb 24, 2022
@tchiotludo
Copy link
Owner

You need to inject topic repository :

@Inject
TopicRepository topicRepository

and add some filtering on partitions based on node id

@jgrammen-agilitypr
Copy link
Contributor Author

There is now a pull request to add the additional "partitions" column. Code is functional as far as I can test (I don't know how to join a second node to the Kafka cluster in docker). Comments are welcome, especially given this is my first time contributing Java code.

@tchiotludo tchiotludo moved this to Done in Backlog Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers node Kafka Node
Projects
Status: Done
Development

No branches or pull requests

2 participants