Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import lodash functions explicitily #1335

Merged
merged 1 commit into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/src/components/Form/Form.jsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';

import Joi from 'joi-browser';
import _ from 'lodash';
import camelCase from 'lodash/camelCase';

import Input from './Input';
import Select from './Select';
Expand Down Expand Up @@ -186,7 +186,7 @@ class Form extends Root {
const items = [];

for (let option of options) {
const value = _.camelCase(option.toString());
const value = camelCase(option.toString());

items[items.length] = {
name: name,
Expand All @@ -199,7 +199,7 @@ class Form extends Root {
return <RadioGroup name={name} label={label} items={items} handleChange={onChange} />;
};

renderDropdown = (name, options, searchValue, selectedKeySchema, onChange, renderResults) => {
renderDropdown = (name, searchValue, selectedKeySchema, onChange, renderResults) => {
return (
<React.Fragment>
<div className="form-group row">
Expand Down
10 changes: 5 additions & 5 deletions client/src/containers/Connect/ConnectCreate/ConnectCreate.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Header from '../../Header/Header';
import constants from '../../../utils/constants';
import Select from '../../../components/Form/Select';
import AceEditor from 'react-ace';
import _ from 'lodash';
import chain from 'lodash/chain';
import 'ace-builds/webpack-resolver';
import 'ace-builds/src-noconflict/mode-json';
import 'ace-builds/src-noconflict/theme-merbivore_soft';
Expand Down Expand Up @@ -53,7 +53,7 @@ class ConnectCreate extends Root {
});
};

handleShema(definitions) {
handleSchema(definitions) {
this.schema = {};
let formData = {};
formData.type = this.state.selectedType;
Expand Down Expand Up @@ -218,7 +218,7 @@ class ConnectCreate extends Root {
let actualGroup = '';
let sameGroup = [];
let allOfIt = [];
_(plugin.definitions)
chain(plugin.definitions)
.filter(plugin => plugin.name !== 'name' && plugin.name !== 'connector.class')
.value()
.forEach(definition => {
Expand Down Expand Up @@ -320,8 +320,8 @@ class ConnectCreate extends Root {
let plugin = this.getPlugin();
if (plugin.definitions) {
this.setState({ plugin }, () => {
this.handleShema(
_(plugin.definitions)
this.handleSchema(
chain(plugin.definitions)
.filter(plugin => plugin.name !== 'name' && plugin.name !== 'connector.class')
.value()
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
import constants from '../../../../utils/constants';
import Form from '../../../../components/Form/Form';
import AceEditor from 'react-ace';
import _ from 'lodash';
import chain from 'lodash/chain';
import 'ace-builds/webpack-resolver';
import 'ace-builds/src-noconflict/mode-json';
import 'ace-builds/src-noconflict/theme-merbivore_soft';
Expand Down Expand Up @@ -234,7 +234,7 @@ class ConnectConfigs extends Form {
let actualGroup = '';
let sameGroup = [];
let allOfIt = [];
_(plugin.definitions)
chain(plugin.definitions)
.filter(plugin => plugin.name !== 'name' && plugin.name !== 'connector.class')
.value()
.forEach(definition => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import Enzyme, { shallow } from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';
import ConsumerGroupUpdate from './ConsumerGroupUpdate';
import { createMemoryHistory } from 'history';
import _ from 'lodash';

Enzyme.configure({ adapter: new Adapter() });

Expand Down
4 changes: 2 additions & 2 deletions client/src/containers/SideBar/Sidebar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import { Link, withRouter } from 'react-router-dom';
import { matchPath } from 'react-router';
import constants from '../../utils/constants';
import _ from 'lodash';
import chain from 'lodash/chain';
import './styles.scss';
import SideNav, { NavIcon, NavItem, NavText } from '@trendmicro/react-sidenav';
import '@trendmicro/react-sidenav/dist/react-sidenav.css';
Expand Down Expand Up @@ -59,7 +59,7 @@ class Sidebar extends Component {

const clusterId = match ? match.params.clusterId || '' : '';
let allClusters =
_(clusters)
chain(clusters)
.sortBy(cluster => cluster.id)
.value() || [];
const cluster = allClusters.find(cluster => cluster.id === clusterId);
Expand Down
17 changes: 5 additions & 12 deletions client/src/containers/Tail/Tail.jsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import Dropdown from 'react-bootstrap/Dropdown';
import _ from 'lodash';
import remove from 'lodash/remove';
import Input from '../../components/Form/Input';
import Header from '../Header';
import { SETTINGS_VALUES } from '../../utils/constants';
Expand Down Expand Up @@ -133,17 +133,10 @@ class Tail extends Root {

handleSelectedTopics = topic => {
let selectedTopics = this.state.selectedTopics;
if (
selectedTopics.find(el => {
return el === topic;
})
) {
let updatedSelected = _.remove(selectedTopics, el => {
return el !== topic;
});
this.setState({
selectedTopics: updatedSelected
});
if (selectedTopics.find(el => el === topic)) {
let updatedSelected = remove(selectedTopics, el => el !== topic);

this.setState({ selectedTopics: updatedSelected });
} else {
selectedTopics.push(topic);
this.setState({ selectedTopics: selectedTopics });
Expand Down
12 changes: 6 additions & 6 deletions client/src/containers/Topic/Topic/TopicData/TopicData.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
import Pagination from '../../../../components/Pagination/Pagination';
import moment from 'moment';
import DatePicker from '../../../../components/DatePicker';
import _ from 'lodash';
import camelCase from 'lodash/camelCase';
import constants from '../../../../utils/constants';
import AceEditor from 'react-ace';
import ConfirmModal from '../../../../components/Modal/ConfirmModal';
Expand Down Expand Up @@ -607,10 +607,10 @@ class TopicData extends Root {
let offsets = this.state.offsets;
for (i = 0; i < offsetsOptions.length; i++) {
const option = offsetsOptions[i];
const camelcaseOption = _.camelCase(option);
const camelCaseOption = camelCase(option);

if (offsets[camelcaseOption] === undefined) {
offsets[camelcaseOption] = '';
if (offsets[camelCaseOption] === undefined) {
offsets[camelCaseOption] = '';
this.setState({ offsets });
}

Expand All @@ -623,10 +623,10 @@ class TopicData extends Root {
type="number"
min="0"
name={`${i}`}
value={offsets[camelcaseOption]}
value={offsets[camelCaseOption]}
onChange={({ currentTarget: input }) => {
let { offsets } = this.state;
offsets[camelcaseOption] = input.value;
offsets[camelCaseOption] = input.value;
this.setState(offsets);
}}
/>
Expand Down
4 changes: 2 additions & 2 deletions client/src/utils/converters.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import lowerCase from 'lodash/lowerCase';
import moment from 'moment';
import { ROLE_TYPE } from './constants';

Expand Down Expand Up @@ -54,7 +54,7 @@ export function handleConvert(value, unit, exclude) {
}

export function handleType(value) {
return _.lowerCase(value.plural);
return lowerCase(value.plural);
}

export function showTime(milliseconds) {
Expand Down