Allow to configure (de)serialiser on consumers/producers #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update node to the latest LTS version * Replace node-sass with sass * Also use the correct version of react-test-renderer. * Update react scripts so we don't use insecure hashing functions * Do not check eslint for production build See tchiotludo#1243 for more information.
Co-authored-by: alozano3 <alozano@caixabanktech.com>
Co-authored-by: Ludovic DEHON <tchiot.ludo@gmail.com>
Co-authored-by: Antoine Chapusot <antoine.chapusot-prestataire@bforbank.com>
Signed-off-by: czomo <tomaszjdul@gmail.com>
…tchiotludo#1291) this can be used to obscure sensitive data from all akhq users
…inside other fields (tchiotludo#1320)
So that we can rely on the same node/npm version
…tab (tchiotludo#1344) close tchiotludo#1336 Co-authored-by: alozano3 <alozano@caixabanktech.com>
Signed-off-by: Dmitrii Bocharov <dmitrii.bocharov@embedit.cz>
- Adding stop condition in newest sort to prevent extra polling - Fixing wrong number of records with pagination close tchiotludo#192
close tchiotludo#1353 Co-authored-by: xinyu.liu <xinyu.liu@coinbase.com>
Co-authored-by: alozano3 <alozano@caixabanktech.com>
close tchiotludo#1400 Co-authored-by: Fredrik Lysén <fredrik.lysen@klarna.com>
…udo#1429) close tchiotludo#912 Co-authored-by: Olivier <oghizzo@xebia.fr>
…1384) close tchiotludo#1183 Co-authored-by: rochelle <graciasrochelle@github.com>
Co-authored-by: Olivier <oghizzo@xebia.fr>
tchiotludo
requested changes
Apr 26, 2023
tchiotludo
pushed a commit
that referenced
this pull request
Jun 26, 2023
markush81
added a commit
to markush81/akhq
that referenced
this pull request
Jun 27, 2023
* dev: chore(deps): update most of java deps fix(schema): invalid signature on schema controller feat(webserver): html-head don't work any more (tchiotludo#1489) feat(schema): improve schema loading on produce screen (tchiotludo#1467) feat(core): allow to configure (de)serialiser on consumers/producers (tchiotludo#1432) feat(topicdata): list topics even if a broker is unable to serve log information (tchiotludo#1502) chore(docs): fix copyright feat(acls): introduce new ACL rewrite (tchiotludo#1472)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I suggest this modification to allow users to be able to override Serializer / Deserializer used by Akhq.
It is usefull when you want different processing per clusterId by providing your compatible Serde (byte[]).
Configure application.yaml and use standard kafka properties on key and value (de)serializer to override ByteArrayDeserializer / ByteArraySerializer.
Providing SerDe seems me the easies way to re-use existing code for users.
Changing KafkaModule ease the way to access producers and consumers configs.
You can re-use per/cluster and default config logic on your serde.
I tried changing Record class and inject a new interface used to manipulate the String rendering of bytes[].
A lot more code is needed and user needs to implement such a dedicated thing.