This repository has been archived by the owner on Jan 8, 2021. It is now read-only.
fix for php 5.5.35/5.6.21/7.0.6 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
changed the title
|
Another notice, in all case, with 7.1, negative offset will mean "from the end" |
voku
added a commit
to voku/portable-utf8
that referenced
this pull request
Apr 28, 2016
This was referenced May 18, 2016
|
Thank you @remicollet |
fabpot
added a commit
to symfony/polyfill
that referenced
this pull request
May 18, 2016
This PR was merged into the 1.1-dev branch. Discussion ---------- Fix tests for php 5.5.35/5.6.21/7.0.6 See tchwork/utf8#59 Commits ------- 99a2aeb Fix tests for php 5.5.35/5.6.21/7.0.6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security fix for #72061 introduce a minor change.
When offset is < 0, grapheme_strrpos return false (not 0)
This make test suite pass again.
P.S. PHP Release Managers are aware of this small change (waiting for their official and final answer)
P.S.2: detected by Fedora QA: See https://apps.fedoraproject.org/koschei/package/php-patchwork-utf8