Skip to content

Commit

Permalink
Add TODO linking to knative#2127.
Browse files Browse the repository at this point in the history
  • Loading branch information
Nghia Tran committed Oct 5, 2018
1 parent 768bc84 commit e0cfeda
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pkg/apis/networking/v1alpha1/clusteringress_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ type ClusterIngressList struct {
// IngressSpec describes the ClusterIngress the user wishes to exist.
//
// In general this follow the same shape as K8s Ingress. Some notable differences:
// - Backends now can have namespace/
// - Backends now can have namespace:
// - Traffic can be split across multiple backends.
// - Timeout & Retry can be configured.
// - Headers can be appended.
Expand All @@ -95,6 +95,11 @@ type IngressSpec struct {
// A list of host rules used to configure the ClusterIngress.
// +optional
Rules []ClusterIngressRule `json:"rules,omitempty"`

// TODO: We need to consider a way to specify if the ClusterIngress address
// should be exposed to the Internet, or only exposed privately (cluster local,
// VPC, RFC1918). An example use case is for
// https://github.com/knative/serving/issues/2127.
}

// ClusterIngressTLS describes the transport layer security associated with an ClusterIngress.
Expand Down

0 comments on commit e0cfeda

Please sign in to comment.