New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/config wizard use config path #473

Merged

tconbeer merged 2 commits into main from feat/config-wizard-use-config-path

Feb 22, 2024

Owner

tconbeer commented Feb 22, 2024 •

edited

Loading

Closes #466 , closes #471

This changes the --config CLI option to accept the config-path param. The more consequential change is the overhaul of the config file search.

Does this PR require a change to Harlequin's docs?

No.
Yes, and I have opened a PR at fix: update config file search paths harlequin-web#64
Yes; I haven't opened a PR, but the gist of the change is: ...

Did you add or update tests for this change?

Yes.
No, I believe tests aren't necessary.
No, I need help with testing this change.

Please complete the following checklist:

I have added an entry to CHANGELOG.md, under the [Unreleased] section heading. That entry references the issue closed by this PR.
I acknowledge Harlequin's MIT license. I do not own my contribution.

tconbeer added 2 commits

February 22, 2024 13:54


          feat: --config uses --config-path and defaults to search path

2998b2a


          feat: add config home to config search path

8e06279

tconbeer merged commit de12035 into main

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet