Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check failure with German characters in heading links #209

Closed
MikeMcC399 opened this issue Jun 9, 2022 · 5 comments
Closed

Check failure with German characters in heading links #209

MikeMcC399 opened this issue Jun 9, 2022 · 5 comments

Comments

@MikeMcC399
Copy link

markdown-link-check version: 3.10.1 and 3.10.2

Problem description

Links to markdown document headings which contain German characters Umlaut and Eszett (äÄöÖüÜß) fail in the current markdown-link-check version 3.10.2 with a message similar to

ERROR: 1 dead links found!
  [✖] #%C3%BCbersicht → Status: 404

This is a regression from earlier versions. In markdown-link-check version 3.10.0 the link checks with German characters pass.

Steps to reproduce

Create document test.md with the following contents:

- [Übersicht](#übersicht)

# Übersicht

(The table of contents was produced using Visual Studio Code extension Markdown All in One and the command "Create Table of Contents".)

Execute
npx markdown-link-check ./test.md

which fails showing

FILE: ./test.md
  [✖] #%C3%BCbersicht

  1 links checked.

  ERROR: 1 dead links found!
  [✖] #%C3%BCbersicht → Status: 404

Comparison to 3.10.0

$ npx markdown-link-check ./test.md

FILE: ./test.md
  [✓] #übersicht

  1 links checked.
@autoantwort
Copy link

If you need a working version you can use autoantwort-markdown-link-check as a temporary workaround (Original version with applied fixes).

@MikeMcC399
Copy link
Author

MikeMcC399 commented Jul 4, 2022

@autoantwort

If you need a working version you can use autoantwort-markdown-link-check as a temporary workaround (Original version with applied fixes).

@autoantwort
Copy link

No I don't think so. So it worked before 6522186 ?

@MikeMcC399
Copy link
Author

@autoantwort

autoantwort-markdown-link-check@3.10.10 passes checking the test file I provided in this issue 👍🏻

$ npx autoantwort-markdown-link-check ./test.md

FILE: ./test.md
  [✓] #übersicht

  1 links checked.

It does however fail checking a markdown file with an anchor embedded in HTML (see open issue #195):

[HTML list item](#html-list-item)

- <a name=html-list-item>HTML list item</a>
$ npx autoantwort-markdown-link-check ./anchor-in-html-test.md

FILE: ./anchor-in-html-test.md
  [✖] #html-list-item

  1 links checked.

  ERROR: 1 dead links found!
  [✖] #html-list-item → Status: 404

so I will stay with "markdown-link-check": "~3.8.7" for the time-being.

@MikeMcC399
Copy link
Author

I can no longer reproduce the issue "Check failure with German characters in heading links" so I assume that it was caused (and fixed) by one of the dependencies.

markdown-link-check@3.10.3

$ npx markdown-link-check ./test.md

FILE: ./test.md
  [✓] #%C3%BCbersicht

  1 links checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants