Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why remove anchor link extraction? #24

Open
adoyle-h opened this issue Dec 11, 2022 · 6 comments
Open

Why remove anchor link extraction? #24

adoyle-h opened this issue Dec 11, 2022 · 6 comments

Comments

@adoyle-h
Copy link

It causes a bug in markdown-link-check.

aepfli added a commit to aepfli/markdown-link-extractor that referenced this issue Jan 11, 2023
Anchor detection got removed during refactoring, as a link will
still point to a sufficient url with a broken anchor, it still
generates wrong/broken links. Especially when markdown is used
to generate pages which are checked with tools like HTMLtest,
which do verify proper anchors etc.

Therefore i reintroduce this change with this pr, but as a
configurable option. This should still allow the proper
outcome of the refactoring, but ensures backwards compatibility
for other users who rely on proper anchor handling.

Relates: tcort#24

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
Copy link
Contributor

aepfli commented Jan 11, 2023

I experienced this issue and stumbled upon this ticket. I am also unsure why it got removed, but I see failing tests with HTMLtest due to this "bug." Therefore I created a proposal pr - maybe it suits both sides.

aepfli added a commit to aepfli/markdown-link-extractor that referenced this issue Jan 11, 2023
Anchor detection got removed during refactoring, as a link will
still point to a sufficient url with a broken anchor, it still
generates wrong/broken links. Especially when markdown is used
to generate pages which are checked with tools like HTMLtest,
which do verify proper anchors etc.

Therefore i reintroduce this change with this pr, but as a
configurable option. This should still allow the proper
outcome of the refactoring, but ensures backwards compatibility
for other users who rely on proper anchor handling.

Relates: tcort#24

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli added a commit to aepfli/markdown-link-extractor that referenced this issue Jan 11, 2023
Anchor detection got removed during refactoring, as a link will
still point to a sufficient url with a broken anchor, it still
generates wrong/broken links. Especially when markdown is used
to generate pages which are checked with tools like HTMLtest,
which do verify proper anchors etc.

Therefore i reintroduce this change with this pr, but as a
configurable option. This should still allow the proper
outcome of the refactoring, but ensures backwards compatibility
for other users who rely on proper anchor handling.

Relates: tcort#24

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
Copy link
Contributor

aepfli commented Jan 12, 2023

tcort/markdown-link-check#212 is also related

@aepfli
Copy link
Contributor

aepfli commented Apr 4, 2023

@tcort should I keep my pr open, or should I close it?

@tcort
Copy link
Owner

tcort commented Mar 10, 2024

PR Merged

@tcort tcort closed this as completed Mar 10, 2024
@tcort
Copy link
Owner

tcort commented Mar 10, 2024

Reverted. The changes don't work with the latest marked (v12.0.1).

@dklimpel
Copy link
Contributor

Reverted. The changes don't work with the latest marked (v12.0.1).

Do you have some more details? Unit tests does not failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants