Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with TeamCity 2018.1.2 #112

Closed
htonheim opened this issue Sep 1, 2018 · 4 comments
Closed

Incompatible with TeamCity 2018.1.2 #112

htonheim opened this issue Sep 1, 2018 · 4 comments
Labels
Milestone

Comments

@htonheim
Copy link

htonheim commented Sep 1, 2018

Expected Behavior

TeamCity should work.

Current Behavior

TeamCity UI breaks down completely. teamcity-server.log is full of "Unexpected response while executing internal Rest API request". See https://youtrack.jetbrains.com/issue/TW-56626.

Steps to Reproduce (for bugs)

  1. Upgrade to TeamCity 2018.1.2.
  2. Install TcWebHooks 1.1-alpha17.235.3543.
  3. Watch the world burn.

Your Environment

  • tcWebHooks Version: 1.1-alpha17.235.354
  • TeamCity Version: 2018.1.2.
  • TeamCity server Operating System: Windows 2008R2
  • Are you using a WebHook Template?: No
@netwolfuk
Copy link
Member

Thanks for the heads up. Updating TeamCity to 2018.1.2 now to check.

netwolfuk added a commit that referenced this issue Sep 1, 2018
The most recent version of the ExceptionMapperUtil file is extracted
from the SVN history, and copied into the project locally.

This is a temporary workaround to address
https://youtrack.jetbrains.com/issue/TW-56626 and
#112

The actual problem is caused by the removal of
src/jetbrains/buildServer/server/rest/jersey/ExceptionMapperUtil.java.

The replacement appears to be to extend ExceptionMapperBase instead,
however the ExceptionMapperBase class appears to force the response to
be text/plain, because it takes a ResponseData object and builds a
Jersey Response object itself. Previously, we were free to return our
own Response object, and could serialise the response as JSON or XML if
that was helpful.
@netwolfuk
Copy link
Member

Hi @htonheim.

As mentioned on the YouTrack ticket, removing the Web Hooks REST API (tcWebHooks) plugin from the Administation -> Plugins page on the TeamCity server and restarting TeamCity will resolve this issue. You do not need to uninstall the Web Hooks (tcWebHooks) plugin.

I am testing a fix for this issue at the moment, and hope to do a release shortly.

@netwolfuk
Copy link
Member

@netwolfuk
Copy link
Member

Issue is resolved by new release.

netwolfuk added a commit that referenced this issue Sep 11, 2018
The most recent version of the ExceptionMapperUtil file is extracted
from the SVN history, and copied into the project locally.

This is a temporary workaround to address
https://youtrack.jetbrains.com/issue/TW-56626 and
#112

The actual problem is caused by the removal of
src/jetbrains/buildServer/server/rest/jersey/ExceptionMapperUtil.java.

The replacement appears to be to extend ExceptionMapperBase instead,
however the ExceptionMapperBase class appears to force the response to
be text/plain, because it takes a ResponseData object and builds a
Jersey Response object itself. Previously, we were free to return our
own Response object, and could serialise the response as JSON or XML if
that was helpful.
@netwolfuk netwolfuk added the bug label Oct 18, 2018
@netwolfuk netwolfuk added this to the v1.1 milestone Oct 18, 2018
netwolfuk added a commit that referenced this issue Apr 10, 2024
The most recent version of the ExceptionMapperUtil file is extracted
from the SVN history, and copied into the project locally.

This is a temporary workaround to address
https://youtrack.jetbrains.com/issue/TW-56626 and
#112

The actual problem is caused by the removal of
src/jetbrains/buildServer/server/rest/jersey/ExceptionMapperUtil.java.

The replacement appears to be to extend ExceptionMapperBase instead,
however the ExceptionMapperBase class appears to force the response to
be text/plain, because it takes a ResponseData object and builds a
Jersey Response object itself. Previously, we were free to return our
own Response object, and could serialise the response as JSON or XML if
that was helpful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants