Removed repeating code and improved readability #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudozermaks
changed the title
dudozermaks
commented
Jan 27, 2023
| music.append(file) | ||
| file_extension = file.split(".")[-1] | ||
|
|
||
| if file_extension in supported_formats: |
There was a problem hiding this comment.
in statement checks if supported_formats (array) has file_extension
There was a problem hiding this comment.
Nice optimizations! Merging your pr!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cool instrument! If you have any questions about my pr, feel free to ask!