Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CLI minifier segfaults on anything create by Deno bundle #324

Closed
dschissler opened this issue Aug 28, 2020 · 4 comments
Closed

The CLI minifier segfaults on anything create by Deno bundle #324

dschissler opened this issue Aug 28, 2020 · 4 comments

Comments

@dschissler
Copy link

dschissler commented Aug 28, 2020

Linux host 5.4.0-42-generic #46-Ubuntu SMP Fri Jul 10 00:24:02 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Using v2.9.0 amd64 release binary from github.

First generate a bundle with deno bundle input.ts output.js. The bundle works in the browser but minify cannot process it. Even something as simple as a hello world console log. It begins to output javascript to stdout and then it segfaults.

Steps to ultimate life failure:

  1. Create a console.log('Hello world') named input.ts.
  2. Run deno bundle input.ts output.js
  3. Run minify output.js
@tdewolff
Copy link
Owner

tdewolff commented Aug 28, 2020

Could you post the contents of output.js please? That will help me track down the problem. Installed deno myself and getting the same segfault. Working on a solution.

By the way, calling minify output.js will output to stdout, if you want to overwrite the file you have to say so explicitly: minify -o output.js output.js

@dschissler
Copy link
Author

Ok, I was just about to post the contents now. This one is just incredibly easy to reproduce. A rare bug indeed ;).

@tdewolff
Copy link
Owner

Thanks for the bug report! I'll release a new version (very) soon!

@tdewolff
Copy link
Owner

Released in v2.9.1, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants